Bug 42693 – WebKitTestRunner needs layoutTestController.setPrinting

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

WebKitTestRunner needs layoutTestController.setPrinting

[Sam Weinig]

<rdar://problem/8213845>

[Alex Christensen]

Created attachment 201643 [details]
Patch

[Darin Adler]

Comment on attachment 201643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201643&action=review

> Source/WebKit2/ChangeLog:16
> +        (WebPage):

You should leave out this line. It’s really just a symptom of a bug in prepare-ChangeLog.

[Alex Christensen]

Created attachment 201646 [details]
Patch

[Alex Christensen]

Created attachment 201651 [details]
Patch

[Darin Adler]

Comment on attachment 201651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201651&action=review

> Tools/ChangeLog:17
> +        (TestRunner):

Bogus line added by prepare-ChangeLog.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:879
> +            WKRetainPtr<WKStringRef> text(AdoptWK, WKBundlePageCopyRenderTreeExternalRepresentationForPrinting(m_page));
> +            stringBuilder.append(toWTFString(text));

Should use adoptWK function, not the AdoptWK constructor, here. Also probably reads better without a local variable, like this:

    stringBuilder.append(toWTFString(adoptWK(WKBundlePageCopyRenderTreeExternalRepresentationForPrinting(m_page)).get()));

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:882
> +            WKRetainPtr<WKStringRef> text(AdoptWK, WKBundlePageCopyRenderTreeExternalRepresentation(m_page));
> +            stringBuilder.append(toWTFString(text));        

Ditto.

[Alex Christensen]

Created attachment 201658 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 201658 [details]
Patch

Clearing flags on attachment: 201658

Committed r150046: <http://trac.webkit.org/changeset/150046>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.