Bug 42691 - WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
Summary: WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-07-20 15:15 PDT by Sam Weinig
Modified: 2012-09-14 08:18 PDT (History)
7 users (show)

See Also:

Attachments
WIP patch (6.07 KB, patch)
2011-03-22 17:38 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Patch (9.50 KB, patch)
2012-09-14 07:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-20 15:15:21 PDT 
WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
Comment 1 Sam Weinig 2010-07-20 15:31:41 PDT 
<rdar://problem/8213848>
Comment 2 Alexey Proskuryakov 2011-03-22 17:38:38 PDT 
Created attachment 86552 [details]
WIP patch

This implements the LayoutTestController method, but WebKit2 fails with an assertion because WebFrameProxy doesn't believe in injected bundles.

void WebFrameProxy::didFailProvisionalLoad()
{
    ASSERT(m_loadState == LoadStateProvisional);
    m_loadState = LoadStateFinished;
    m_provisionalURL = String();
}
Comment 3 Chris Dumez 2012-09-14 07:29:02 PDT 
Created attachment 164147 [details]
Patch
Comment 4 WebKit Review Bot 2012-09-14 08:18:17 PDT 
Comment on attachment 164147 [details]
Patch

Clearing flags on attachment: 164147

Committed r128612: <http://trac.webkit.org/changeset/128612>
Comment 5 WebKit Review Bot 2012-09-14 08:18:20 PDT 
All reviewed patches have been landed.  Closing bug.