WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
42682
WebKitTestRunner needs layoutTestController.setPOSIXLocale
https://bugs.webkit.org/show_bug.cgi?id=42682
Summary
WebKitTestRunner needs layoutTestController.setPOSIXLocale
Sam Weinig
Reported
2010-07-20 15:12:45 PDT
WebKitTestRunner needs layoutTestController.setPOSIXLocale
Attachments
Patch
(5.37 KB, patch)
2011-01-28 17:36 PST
,
Maciej Stachowiak
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2010-07-20 15:32:35 PDT
<
rdar://problem/8213862
>
Maciej Stachowiak
Comment 2
2011-01-28 17:36:41 PST
Created
attachment 80529
[details]
Patch
Darin Adler
Comment 3
2011-01-28 17:59:05 PST
Comment on
attachment 80529
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=80529&action=review
> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:378 > + JSStringGetUTF8CString(locale, localeBuf, sizeof(localeBuf)); > + setlocale(LC_ALL, localeBuf);
Would be nicer to safely do nothing if JSStringGetUTF8CString fails.
Maciej Stachowiak
Comment 4
2011-01-28 18:25:54 PST
Committed
r77042
: <
http://trac.webkit.org/changeset/77042
>
WebKit Review Bot
Comment 5
2011-01-28 19:31:25 PST
http://trac.webkit.org/changeset/77042
might have broken GTK Linux 64-bit Debug
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug