Bug 42682 - WebKitTestRunner needs layoutTestController.setPOSIXLocale
Summary: WebKitTestRunner needs layoutTestController.setPOSIXLocale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-07-20 15:12 PDT by Sam Weinig
Modified: 2011-01-28 19:31 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.37 KB, patch)
2011-01-28 17:36 PST, Maciej Stachowiak 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-20 15:12:45 PDT 
WebKitTestRunner needs layoutTestController.setPOSIXLocale
Comment 1 Sam Weinig 2010-07-20 15:32:35 PDT 
<rdar://problem/8213862>
Comment 2 Maciej Stachowiak 2011-01-28 17:36:41 PST 
Created attachment 80529 [details]
Patch
Comment 3 Darin Adler 2011-01-28 17:59:05 PST 
Comment on attachment 80529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80529&action=review

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:378
> +    JSStringGetUTF8CString(locale, localeBuf, sizeof(localeBuf));
> +    setlocale(LC_ALL, localeBuf);

Would be nicer to safely do nothing if JSStringGetUTF8CString fails.
Comment 4 Maciej Stachowiak 2011-01-28 18:25:54 PST 
Committed r77042: <http://trac.webkit.org/changeset/77042>
Comment 5 WebKit Review Bot 2011-01-28 19:31:25 PST 
http://trac.webkit.org/changeset/77042 might have broken GTK Linux 64-bit Debug