Bug 42675 - WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonLoadingScript
Summary: WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords: InRadar
: 98141 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-20 14:35 PDT by Sam Weinig
Modified: 2012-10-22 01:43 PDT (History)
5 users (show)

See Also:


Attachments
patch (12.33 KB, patch)
2012-10-18 03:03 PDT, Mikhail Pozdnyakov
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch v2 (13.15 KB, patch)
2012-10-18 05:13 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
patch v3 (14.63 KB, patch)
2012-10-22 00:33 PDT, Mikhail Pozdnyakov
kenneth: review+
Details | Formatted Diff | Diff
to be landed (14.65 KB, patch)
2012-10-22 01:19 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-20 14:35:54 PDT
WebKitTestRunner needs layoutTestController.queueLoadingScript
Comment 1 Sam Weinig 2010-07-20 15:33:10 PDT
<rdar://problem/8213870>
Comment 2 Mikhail Pozdnyakov 2012-10-18 03:03:34 PDT
Created attachment 169379 [details]
patch
Comment 3 Build Bot 2012-10-18 03:07:34 PDT
Comment on attachment 169379 [details]
patch

Attachment 169379 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14390918
Comment 4 Mikhail Pozdnyakov 2012-10-18 05:13:44 PDT
Created attachment 169394 [details]
patch v2

should satisfy MAC compiler
Comment 5 Kenneth Rohde Christiansen 2012-10-21 03:40:41 PDT
Comment on attachment 169394 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=169394&action=review

> Tools/WebKitTestRunner/WorkQueueManager.cpp:169
> +    enqueue(new ScriptItem</*loading*/ true>(script));

Wouldnt this be nicer with an enum?
Comment 6 Mikhail Pozdnyakov 2012-10-22 00:33:57 PDT
Created attachment 169838 [details]
patch v3

Introduced enum as work queue operation result. Thanks, Kenneth
Comment 7 Kenneth Rohde Christiansen 2012-10-22 01:02:02 PDT
Comment on attachment 169838 [details]
patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=169838&action=review

> Tools/WebKitTestRunner/WorkQueueManager.cpp:61
> +        NotLoading

NonLoading? or DisallowLoading, AllowLoading?
Comment 8 Mikhail Pozdnyakov 2012-10-22 01:06:19 PDT
(In reply to comment #7)
> (From update of attachment 169838 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169838&action=review
> 
> > Tools/WebKitTestRunner/WorkQueueManager.cpp:61
> > +        NotLoading
> 
> NonLoading? or DisallowLoading, AllowLoading?

Think NonLoading is better
Comment 9 Mikhail Pozdnyakov 2012-10-22 01:19:55 PDT
Created attachment 169846 [details]
to be landed

NotLoading -> NonLoading
Comment 10 WebKit Review Bot 2012-10-22 01:42:17 PDT
Comment on attachment 169846 [details]
to be landed

Clearing flags on attachment: 169846

Committed r132041: <http://trac.webkit.org/changeset/132041>
Comment 11 WebKit Review Bot 2012-10-22 01:42:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Mikhail Pozdnyakov 2012-10-22 01:43:13 PDT
*** Bug 98141 has been marked as a duplicate of this bug. ***