RESOLVED FIXED 42675
WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonLoadingScript 
https://bugs.webkit.org/show_bug.cgi?id=42675
Summary WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonL...
Sam Weinig
Reported 2010-07-20 14:35:54 PDT
WebKitTestRunner needs layoutTestController.queueLoadingScript
Attachments
patch (12.33 KB, patch)
2012-10-18 03:03 PDT, Mikhail Pozdnyakov 		buildbot: commit-queue-
DetailsFormatted DiffDiff
patch v2 (13.15 KB, patch)
2012-10-18 05:13 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v3 (14.63 KB, patch)
2012-10-22 00:33 PDT, Mikhail Pozdnyakov 		kenneth: review+
DetailsFormatted DiffDiff
to be landed (14.65 KB, patch)
2012-10-22 01:19 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:33:10 PDT
<rdar://problem/8213870>
Mikhail Pozdnyakov
Comment 2 2012-10-18 03:03:34 PDT
Created attachment 169379 [details] patch
Build Bot
Comment 3 2012-10-18 03:07:34 PDT
Comment on attachment 169379 [details] patch Attachment 169379 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14390918
Mikhail Pozdnyakov
Comment 4 2012-10-18 05:13:44 PDT
Created attachment 169394 [details] patch v2 should satisfy MAC compiler
Kenneth Rohde Christiansen
Comment 5 2012-10-21 03:40:41 PDT
Comment on attachment 169394 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=169394&action=review > Tools/WebKitTestRunner/WorkQueueManager.cpp:169 > + enqueue(new ScriptItem</*loading*/ true>(script)); Wouldnt this be nicer with an enum?
Mikhail Pozdnyakov
Comment 6 2012-10-22 00:33:57 PDT
Created attachment 169838 [details] patch v3 Introduced enum as work queue operation result. Thanks, Kenneth
Kenneth Rohde Christiansen
Comment 7 2012-10-22 01:02:02 PDT
Comment on attachment 169838 [details] patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=169838&action=review > Tools/WebKitTestRunner/WorkQueueManager.cpp:61 > + NotLoading NonLoading? or DisallowLoading, AllowLoading?
Mikhail Pozdnyakov
Comment 8 2012-10-22 01:06:19 PDT
(In reply to comment #7) > (From update of attachment 169838 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169838&action=review > > > Tools/WebKitTestRunner/WorkQueueManager.cpp:61 > > + NotLoading > > NonLoading? or DisallowLoading, AllowLoading? Think NonLoading is better
Mikhail Pozdnyakov
Comment 9 2012-10-22 01:19:55 PDT
Created attachment 169846 [details] to be landed NotLoading -> NonLoading
WebKit Review Bot
Comment 10 2012-10-22 01:42:17 PDT
Comment on attachment 169846 [details] to be landed Clearing flags on attachment: 169846 Committed r132041: <http://trac.webkit.org/changeset/132041>
WebKit Review Bot
Comment 11 2012-10-22 01:42:22 PDT
All reviewed patches have been landed. Closing bug.
Mikhail Pozdnyakov
Comment 12 2012-10-22 01:43:13 PDT
*** Bug 98141 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.