Bug 42673 - make dump-as-markup work better on subframes and allow dumping a subtree
Summary: make dump-as-markup work better on subframes and allow dumping a subtree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 14:35 PDT by Ojan Vafai
Modified: 2010-07-20 15:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.84 KB, patch)
2010-07-20 14:36 PDT, Ojan Vafai
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-07-20 14:35:14 PDT
make dump-as-markup work better on subframes and allow dumping a subtree
Comment 1 Ojan Vafai 2010-07-20 14:36:38 PDT
Created attachment 62114 [details]
Patch
Comment 2 Darin Adler 2010-07-20 15:15:07 PDT
Comment on attachment 62114 [details]
Patch

> +// FIXME: Make description required

Is this really important?

> +/**
> + * The description of what this test is testing. Gets prepended to the dumped markup.
> + */

Why not use // comments everywhere as we do elsewhere in WebKit?

All looks fine.
Comment 3 Ojan Vafai 2010-07-20 15:28:41 PDT
Thanks for the review.

(In reply to comment #2)
> (From update of attachment 62114 [details])
> > +// FIXME: Make description required
> 
> Is this really important?

I'm on the fence. On the one hand it makes the expected results from the test easier to make sense. On the other, it makes tests more of a pain to write. I'll remove the FIXME.

> > +/**
> > + * The description of what this test is testing. Gets prepended to the dumped markup.
> > + */
> 
> Why not use // comments everywhere as we do elsewhere in WebKit?

Ugh. Just habit from Google-style JavaScript. I'll change it over to // comments.
Comment 4 Ojan Vafai 2010-07-20 15:39:37 PDT
Committed r63781: <http://trac.webkit.org/changeset/63781>