RESOLVED FIXED42673
make dump-as-markup work better on subframes and allow dumping a subtree 
https://bugs.webkit.org/show_bug.cgi?id=42673
Summary make dump-as-markup work better on subframes and allow dumping a subtree
Ojan Vafai
Reported 2010-07-20 14:35:14 PDT
make dump-as-markup work better on subframes and allow dumping a subtree
Attachments
Patch (5.84 KB, patch)
2010-07-20 14:36 PDT, Ojan Vafai 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-07-20 14:36:38 PDT
Created attachment 62114 [details] Patch
Darin Adler
Comment 2 2010-07-20 15:15:07 PDT
Comment on attachment 62114 [details] Patch > +// FIXME: Make description required Is this really important? > +/** > + * The description of what this test is testing. Gets prepended to the dumped markup. > + */ Why not use // comments everywhere as we do elsewhere in WebKit? All looks fine.
Ojan Vafai
Comment 3 2010-07-20 15:28:41 PDT
Thanks for the review. (In reply to comment #2) > (From update of attachment 62114 [details]) > > +// FIXME: Make description required > > Is this really important? I'm on the fence. On the one hand it makes the expected results from the test easier to make sense. On the other, it makes tests more of a pain to write. I'll remove the FIXME. > > +/** > > + * The description of what this test is testing. Gets prepended to the dumped markup. > > + */ > > Why not use // comments everywhere as we do elsewhere in WebKit? Ugh. Just habit from Google-style JavaScript. I'll change it over to // comments.
Ojan Vafai
Comment 4 2010-07-20 15:39:37 PDT
Committed r63781: <http://trac.webkit.org/changeset/63781>
Note You need to log in before you can comment on or make changes to this bug.