Bug 42662 - When GraphicsLayer::contentsOrientation() is CompositingCoordinatesBottomUp, need to flip repaint rects
Summary: When GraphicsLayer::contentsOrientation() is CompositingCoordinatesBottomUp, ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on:
Blocks: 41084
  Show dependency treegraph
Reported: 2010-07-20 13:45 PDT by Simon Fraser (smfr)
Modified: 2010-07-21 09:56 PDT (History)
0 users

See Also:

Patch (8.13 KB, patch)
2010-07-20 14:00 PDT, Simon Fraser (smfr)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-07-20 13:45:18 PDT
When a GraphicsLayer's contentsOrientation() is CompositingCoordinatesBottomUp, we need to flip the rects sent to setNeedsDisplayInRect:, just as we flip when drawing.
Comment 1 Simon Fraser (smfr) 2010-07-20 14:00:02 PDT
Created attachment 62108 [details]
Comment 2 Darin Adler 2010-07-20 15:02:34 PDT
Comment on attachment 62108 [details]

> +        struct objc_super r = { layer, class_getSuperclass(object_getClass(layer)) };

Can you come up with a word to use here, instead of the letter "r"? Maybe "layerSuper" or "receiver" or "layerSuperReceiver" or "superReceiver"?
Comment 3 Simon Fraser (smfr) 2010-07-21 09:56:30 PDT