Bug 42657 - [Chromium] Add interface for downloading to a file via WebURLLoader.
Summary: [Chromium] Add interface for downloading to a file via WebURLLoader.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 12:34 PDT by Darin Fisher (:fishd, Google)
Modified: 2010-07-20 12:57 PDT (History)
0 users

See Also:


Attachments
v1 patch (7.97 KB, patch)
2010-07-20 12:36 PDT, Darin Fisher (:fishd, Google)
jianli: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2010-07-20 12:34:38 PDT
[Chromium] Add interface for downloading to a file via WebURLLoader.
Comment 1 Darin Fisher (:fishd, Google) 2010-07-20 12:36:56 PDT
Created attachment 62102 [details]
v1 patch
Comment 2 Jian Li 2010-07-20 12:52:18 PDT
Comment on attachment 62102 [details]
v1 patch

Looks good except one minor comment.

WebKit/chromium/public/WebURLLoaderClient.h:56
 +      // Called when a chunk of response data it downloaded.  This is only called
it => is
Comment 3 Darin Fisher (:fishd, Google) 2010-07-20 12:57:14 PDT
Landed as http://trac.webkit.org/changeset/63769