Bug 42646 - focusing an unfocused contentEditable element should place the cursor at the beginning
Summary: focusing an unfocused contentEditable element should place the cursor at the ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
Depends on:
Reported: 2010-07-20 09:58 PDT by Ojan Vafai
Modified: 2010-08-02 14:04 PDT (History)
10 users (show)

See Also:

test case (213 bytes, text/html)
2010-07-20 09:58 PDT, Ojan Vafai
no flags Details
Patch (89.65 KB, patch)
2010-07-20 11:25 PDT, Ojan Vafai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-07-20 09:58:49 PDT
Created attachment 62087 [details]
test case

Right now it selected the contents of the element. See test case.
Comment 1 Ojan Vafai 2010-07-20 10:40:17 PDT
Looks this the body focus case was fixed at http://trac.webkit.org/changeset/14666, but all cases should be doing this though. I don't see when selecting all the node's contents is ever correct. We should either put the cursor at the beginning, or restore the previous selection (as per the FIXME in Element::updateFocusAppearance.

I'm running a patch through the layout tests now.
Comment 2 Ojan Vafai 2010-07-20 11:25:28 PDT
Created attachment 62094 [details]
Comment 3 Eric Seidel (no email) 2010-08-02 12:10:33 PDT
Comment on attachment 62094 [details]

This looks sane.  I think you're rebaselining some image results you might not need to.
Comment 4 Ojan Vafai 2010-08-02 13:46:29 PDT
Committed r64488: <http://trac.webkit.org/changeset/64488>
Comment 5 WebKit Review Bot 2010-08-02 14:04:53 PDT
http://trac.webkit.org/changeset/64488 might have broken Qt Linux Release