RESOLVED FIXED Bug 42645
focusing the body of a contentEditable iframe resets the selection 
https://bugs.webkit.org/show_bug.cgi?id=42645
Summary focusing the body of a contentEditable iframe resets the selection
Ojan Vafai
Reported 2010-07-20 09:55:02 PDT
See the attached test case.
Attachments
test case (554 bytes, text/html)
2010-07-20 09:55 PDT, Ojan Vafai 		no flags
Details
Patch (4.22 KB, patch)
2010-07-20 13:50 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Update to ToT (4.13 KB, patch)
2010-07-20 15:57 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (4.08 KB, patch)
2010-08-02 13:32 PDT, Ojan Vafai 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-07-20 09:55:21 PDT
Created attachment 62086 [details] test case
Ojan Vafai
Comment 2 2010-07-20 10:41:04 PDT
In fact, there's a FIXME in Element::updateFocusAppearance that we should restore the previous selection if there is one.
Ojan Vafai
Comment 3 2010-07-20 13:50:04 PDT
Created attachment 62107 [details] Patch
Ojan Vafai
Comment 4 2010-07-20 15:57:15 PDT
Created attachment 62126 [details] Update to ToT
Eric Seidel (no email)
Comment 5 2010-08-02 11:28:56 PDT
Comment on attachment 62126 [details] Update to ToT WebCore/dom/Element.cpp:  + if (!frame) Split this out into a separate if, and add a comment as to why we're making this check (what it's supposed to do).
Ojan Vafai
Comment 6 2010-08-02 13:32:30 PDT
Created attachment 63251 [details] Patch
Ojan Vafai
Comment 7 2010-08-02 13:50:48 PDT
Committed r64489: <http://trac.webkit.org/changeset/64489>
Note You need to log in before you can comment on or make changes to this bug.