Bug 42632 - Following change @62542, webkit doesn't compile when the inspector is disabled
Summary: Following change @62542, webkit doesn't compile when the inspector is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 05:54 PDT by Leon Clarke
Modified: 2010-07-20 10:36 PDT (History)
4 users (show)

See Also:

Attachments
Proposed fix (3.78 KB, patch)
2010-07-20 05:58 PDT, Leon Clarke 		no flags Details | Formatted Diff | Diff
Removing whole InspectorDOMAgent (2.88 KB, patch)
2010-07-20 07:04 PDT, Leon Clarke 		pfeldman: review+
leonclarke: commit-queue-
Details | Formatted Diff | Diff
And again with all the files (3.75 KB, patch)
2010-07-20 08:38 PDT, Leon Clarke 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leon Clarke 2010-07-20 05:54:57 PDT 
...and Android currently doesn't use the inspector.
Comment 1 Leon Clarke 2010-07-20 05:58:04 PDT 
Created attachment 62059 [details]
Proposed fix
Comment 2 Pavel Feldman 2010-07-20 06:17:35 PDT 
Hm. Can we hide InspectorDOMAgent instead?
Comment 3 Leon Clarke 2010-07-20 06:27:32 PDT 
At first glance,it looks like that will be a more complex change, however it may well be philosophically tidier. I'll investigate a bit more...
Comment 4 Leon Clarke 2010-07-20 07:04:11 PDT 
Created attachment 62072 [details]
Removing whole InspectorDOMAgent

That looks like a good idea, removing the whole InspectorDOMAgent
Comment 5 Leon Clarke 2010-07-20 08:26:41 PDT 
That patch was missing a file. Hang on...
Comment 6 Leon Clarke 2010-07-20 08:38:29 PDT 
Created attachment 62080 [details]
And again with all the files
Comment 7 WebKit Commit Bot 2010-07-20 10:35:56 PDT 
Comment on attachment 62080 [details]
And again with all the files

Clearing flags on attachment: 62080

Committed r63753: <http://trac.webkit.org/changeset/63753>
Comment 8 WebKit Commit Bot 2010-07-20 10:36:00 PDT 
All reviewed patches have been landed.  Closing bug.