Bug 42623 - [Qt] Setup the QtWebProcess
Summary: [Qt] Setup the QtWebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 03:08 PDT by Balazs Kelemen
Modified: 2010-07-23 06:39 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch (9.23 KB, patch)
2010-07-20 05:06 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
proposed patch (10.09 KB, patch)
2010-07-20 05:27 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
proposed patch with style fixes (10.09 KB, patch)
2010-07-23 04:39 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-07-20 03:08:15 PDT
Since we have the port of the webkit2 core, it is time to setup our WebProcess, creating the entry point and the build environment.
Comment 1 Balazs Kelemen 2010-07-20 05:06:22 PDT
Created attachment 62055 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-07-20 05:09:01 PDT
Attachment 62055 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/qt/MainQt.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/qt/MainQt.cpp:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 5 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Balazs Kelemen 2010-07-20 05:27:31 PDT
Created attachment 62056 [details]
proposed patch

Add WebProcessMainQt.cpp to SOURCES in WebCore.pro, what I forgot in the previous patch.
Comment 4 WebKit Review Bot 2010-07-20 05:29:37 PDT
Attachment 62056 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/qt/MainQt.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/qt/MainQt.cpp:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Balazs Kelemen 2010-07-23 04:39:27 PDT
Created attachment 62412 [details]
proposed patch with style fixes
Comment 6 WebKit Review Bot 2010-07-23 04:41:56 PDT
Attachment 62412 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/qt/MainQt.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:29:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 4 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andras Becsi 2010-07-23 06:39:38 PDT
Comment on attachment 62412 [details]
proposed patch with style fixes

Clearing flags on attachment: 62412

Committed r63968: <http://trac.webkit.org/changeset/63968>
Comment 8 Andras Becsi 2010-07-23 06:39:47 PDT
All reviewed patches have been landed.  Closing bug.