Bug 42622 - Lazy cursor creation should be guarded by #if USE(LAZY_NATIVE_CURSOR) in WebKit2
Summary: Lazy cursor creation should be guarded by #if USE(LAZY_NATIVE_CURSOR) in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 02:00 PDT by Balazs Kelemen
Modified: 2010-07-22 08:04 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (2.53 KB, patch)
2010-07-20 02:05 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-07-20 02:00:08 PDT 
It should not be necessary for a webkit2 port to implement this feature. Actually it is not implemented for qt and we would leave it over and going on with the rest of the work.
Comment 1 Balazs Kelemen 2010-07-20 02:05:48 PDT 
Created attachment 62043 [details]
proposed patch
Comment 2 Antonio Gomes 2010-07-22 07:11:55 PDT 
Comment on attachment 62043 [details]
proposed patch

Looks sane to me since only Mac and Win platforms define that on WebCore.

...
#if PLATFORM(WIN) || PLATFORM(MAC)
#define WTF_USE_LAZY_NATIVE_CURSOR 1
#endif
...

Please if you are planning on doing the real lazy cursor implementation as a follow up, paste the bug# here for reference.
Comment 3 WebKit Commit Bot 2010-07-22 08:04:01 PDT 
Comment on attachment 62043 [details]
proposed patch

Clearing flags on attachment: 62043

Committed r63893: <http://trac.webkit.org/changeset/63893>
Comment 4 WebKit Commit Bot 2010-07-22 08:04:06 PDT 
All reviewed patches have been landed.  Closing bug.