Bug 42620 - Web Inspector: it is possible to show call-stack instead of caller property for Timeline records
Summary: Web Inspector: it is possible to show call-stack instead of caller property f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 01:18 PDT by Ilya Tikhonovsky
Modified: 2010-07-20 12:16 PDT (History)
8 users (show)

See Also:

Attachments
[patch] initial version. (6.18 KB, patch)
2010-07-20 03:02 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
screenshot (32.07 KB, image/png)
2010-07-20 03:09 PDT, Ilya Tikhonovsky 		no flags Details
[patch] second iteration (6.70 KB, patch)
2010-07-20 06:46 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
screenshot (34.65 KB, image/png)
2010-07-20 06:47 PDT, Ilya Tikhonovsky 		no flags Details
[patch] third iteration. (8.48 KB, patch)
2010-07-20 08:42 PDT, Ilya Tikhonovsky 		pfeldman: review+
Details | Formatted Diff | Diff
screenshot (43.29 KB, image/png)
2010-07-20 08:42 PDT, Ilya Tikhonovsky 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-07-20 01:18:04 PDT 
%subj%
Comment 1 Ilya Tikhonovsky 2010-07-20 03:02:27 PDT 
Created attachment 62048 [details]
[patch] initial version.
Comment 2 Ilya Tikhonovsky 2010-07-20 03:09:21 PDT 
Created attachment 62051 [details]
screenshot
Comment 3 Yury Semikhatsky 2010-07-20 03:17:17 PDT 
(In reply to comment #2)
> Created an attachment (id=62051) [details]
> screenshot

The tooltip seems to be overloaded with stack data. We could try to make timeline records expandable and show the stack trace in it.
Comment 4 Ilya Tikhonovsky 2010-07-20 06:46:32 PDT 
Created attachment 62069 [details]
[patch] second iteration
Comment 5 Ilya Tikhonovsky 2010-07-20 06:47:00 PDT 
Created attachment 62070 [details]
screenshot
Comment 6 Pavel Feldman 2010-07-20 07:25:59 PDT 
Should we align the frames by "@"?
Comment 7 Ilya Tikhonovsky 2010-07-20 08:42:28 PDT 
Created attachment 62081 [details]
[patch] third iteration.
Comment 8 Ilya Tikhonovsky 2010-07-20 08:42:52 PDT 
Created attachment 62082 [details]
screenshot
Comment 9 Ilya Tikhonovsky 2010-07-20 12:16:14 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r63757