Bug 42609 - clean up style in ClipboardWin and PasteboardWin
Summary: clean up style in ClipboardWin and PasteboardWin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 18:16 PDT by Tony Chang
Modified: 2010-07-20 01:44 PDT (History)
1 user (show)

See Also:


Attachments
Patch (24.55 KB, patch)
2010-07-19 18:20 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (24.55 KB, patch)
2010-07-19 18:24 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (24.70 KB, patch)
2010-07-19 18:41 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-07-19 18:16:00 PDT
clean up style in ClipboardWin and PasteboardWin
Comment 1 Tony Chang 2010-07-19 18:20:27 PDT
Created attachment 62020 [details]
Patch
Comment 2 Tony Chang 2010-07-19 18:24:17 PDT
Created attachment 62021 [details]
Patch
Comment 3 Tony Chang 2010-07-19 18:24:41 PDT
Comment on attachment 62021 [details]
Patch

This is a precursor to fixing bug 37981
Comment 4 Kent Tamura 2010-07-19 18:31:18 PDT
Comment on attachment 62021 [details]
Patch

>      if (getWebLocData(dataObject, url, title)) {
>          success = true;
> -        return url;
>      } else if (SUCCEEDED(dataObject->GetData(urlWFormat(), &store))) {

nit: We can remove {}.

> -        //URL using unicode
> +        // URL using unicode

nit: unicode -> Unicode

> -        //URL using ascii
> +        // URL using ascii

nit: ascii -> ASCII

> -        //unicode text
> +        // unicode text

ditto.

> -        //ascii text
> +        // ascii text

ditto.
Comment 5 Tony Chang 2010-07-19 18:41:10 PDT
Created attachment 62023 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2010-07-20 01:43:57 PDT
Comment on attachment 62023 [details]
Patch for landing

Clearing flags on attachment: 62023

Committed r63734: <http://trac.webkit.org/changeset/63734>
Comment 7 WebKit Commit Bot 2010-07-20 01:44:01 PDT
All reviewed patches have been landed.  Closing bug.