Bug 42602 - Implement NPN_PostURLNotify
Summary: Implement NPN_PostURLNotify
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2010-07-19 15:56 PDT by Anders Carlsson
Modified: 2010-07-19 17:08 PDT (History)
1 user (show)

See Also:

Patch (20.30 KB, patch)
2010-07-19 16:15 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-19 15:56:54 PDT
Implement NPN_PostURLNotify
Comment 1 Anders Carlsson 2010-07-19 16:15:18 PDT
Created attachment 62008 [details]
Comment 2 WebKit Review Bot 2010-07-19 16:21:01 PDT
Attachment 62008 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:359:  NPN_PostURLNotify is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/PluginController.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-07-19 16:23:17 PDT
Comment on attachment 62008 [details]

I am not sure all the inline's are necessary.
Comment 4 Anders Carlsson 2010-07-19 17:08:07 PDT
Committed r63701: <http://trac.webkit.org/changeset/63701>