RESOLVED FIXED 42586
Log all canceled authentication attempts in DumpRenderTree 
https://bugs.webkit.org/show_bug.cgi?id=42586
Summary Log all canceled authentication attempts in DumpRenderTree
Alexey Proskuryakov
Reported 2010-07-19 12:40:59 PDT
DumpRenderTree already prints a log when it responds with preset credentials, but it doesn't log anything when there are no credentials (and it thus simulates a canceled auth sheet). It's important to know whether an auth sheet appeared.
Attachments
proposed patch (4.13 KB, patch)
2010-07-19 12:42 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-07-19 12:42:57 PDT
Created attachment 61980 [details] proposed patch
Darin Adler
Comment 2 2010-07-19 12:50:16 PDT
Comment on attachment 61980 [details] proposed patch > + NSString *string = [NSString stringWithFormat:@"%@ - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet", identifier]; > + printf("%s\n", [string UTF8String]); I would either use puts instead of printf here, or continue to use printf but use UTF8String on the identifier instead of calling stringWithFormat and have a printf format string instead. r=me
Alexey Proskuryakov
Comment 3 2010-07-19 13:04:55 PDT
Committed <http://trac.webkit.org/changeset/63681>. > I would either use puts instead of printf here, or continue > to use printf but use UTF8String on the identifier instead of > calling stringWithFormat and have a printf format string instead. I didn't make this change, since such style matches what is done elsewhere in this file.
WebKit Review Bot
Comment 4 2010-07-19 13:20:09 PDT
http://trac.webkit.org/changeset/63681 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.