Bug 42584 - Add local storage support for WebKit2
Summary: Add local storage support for WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 12:37 PDT by Sam Weinig
Modified: 2010-07-19 13:08 PDT (History)
0 users

See Also:

Attachments
Patch (8.91 KB, patch)
2010-07-19 12:37 PDT, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-19 12:37:13 PDT 
Add local storage support for WebKit2
Comment 1 Sam Weinig 2010-07-19 12:37:57 PDT 
Created attachment 61978 [details]
Patch
Comment 2 Anders Carlsson 2010-07-19 12:57:03 PDT 
Comment on attachment 61978 [details]
Patch

> Index: WebKit2/Shared/WebPreferencesStore.h
> ===================================================================
> --- WebKit2/Shared/WebPreferencesStore.h	(revision 63671)
> +++ WebKit2/Shared/WebPreferencesStore.h	(working copy)
> @@ -105,6 +109,8 @@ struct WebPreferencesStore {
>      WebCore::String fixedFontFamily;
>      WebCore::String sansSerifFontFamily;
>      WebCore::String serifFontFamily;
> +
> +    WebCore::String localStorage;
>  };
>  
Looks like this isn't used?

Do you also need to remove files from the Skipped list?
Comment 3 Sam Weinig 2010-07-19 13:07:12 PDT 
(In reply to comment #2)
> (From update of attachment 61978 [details])
> > Index: WebKit2/Shared/WebPreferencesStore.h
> > ===================================================================
> > --- WebKit2/Shared/WebPreferencesStore.h	(revision 63671)
> > +++ WebKit2/Shared/WebPreferencesStore.h	(working copy)
> > @@ -105,6 +109,8 @@ struct WebPreferencesStore {
> >      WebCore::String fixedFontFamily;
> >      WebCore::String sansSerifFontFamily;
> >      WebCore::String serifFontFamily;
> > +
> > +    WebCore::String localStorage;
> >  };
> >  
> Looks like this isn't used?

Oops. Removed.

> Do you also need to remove files from the Skipped list?

No, these have not been added yet.
Comment 4 Sam Weinig 2010-07-19 13:08:22 PDT 
Landed in r63682.