Bug 42569 - [EFL] Fix some EFL theme issues
Summary: [EFL] Fix some EFL theme issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 08:10 PDT by Rafael Antognolli
Modified: 2010-07-19 09:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.24 KB, patch)
2010-07-19 08:13 PDT, Rafael Antognolli
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Antognolli 2010-07-19 08:10:46 PDT
[EFL] Fix some EFL theme issues
Comment 1 Rafael Antognolli 2010-07-19 08:13:56 PDT
Created attachment 61957 [details]
Patch
Comment 2 Antonio Gomes 2010-07-19 08:24:49 PDT
Comment on attachment 61957 [details]
Patch


> +        Keep a pointer to theme filename and check for it correctly.

What was wrong previously? from what I understood, instead of having 'theme' and 'file' variables you changed to only have 'file', or you really fixing a problem?
Comment 3 Gustavo Sverzut Barbieri 2010-07-19 08:37:04 PDT
(In reply to comment #2)
> (From update of attachment 61957 [details])
> 
> > +        Keep a pointer to theme filename and check for it correctly.
> 
> What was wrong previously? from what I understood, instead of having 'theme' and 'file' variables you changed to only have 'file', or you really fixing a problem?

The good old annoyance of storing "const char*" that is return of a dynamically allocated String::utf8().data(). Now it is being stored in CString and used as CString::data(), for immediate use, retaining the memory.
Comment 4 Lucas De Marchi 2010-07-19 08:38:51 PDT
(In reply to comment #2)
> (From update of attachment 61957 [details])
> 
> > +        Keep a pointer to theme filename and check for it correctly.
> 
> What was wrong previously? from what I understood, instead of having 'theme' and 'file' variables you changed to only have 'file', or you really fixing a problem?

He was fixing a problem:

> - file = edjeThemeRecursive().utf8().data();

The object returned by .utf8() will die as soon as .data() is returned. Thus 'file' will point for a memory area that is not allocated anymore.
Comment 5 WebKit Commit Bot 2010-07-19 09:06:25 PDT
Comment on attachment 61957 [details]
Patch

Clearing flags on attachment: 61957

Committed r63666: <http://trac.webkit.org/changeset/63666>
Comment 6 WebKit Commit Bot 2010-07-19 09:06:29 PDT
All reviewed patches have been landed.  Closing bug.