Bug 42569 – [EFL] Fix some EFL theme issues

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Rafael Antognolli]

[EFL] Fix some EFL theme issues

[Rafael Antognolli]

Created attachment 61957 [details]
Patch

[Antonio Gomes]

Comment on attachment 61957 [details]
Patch


> +        Keep a pointer to theme filename and check for it correctly.

What was wrong previously? from what I understood, instead of having 'theme' and 'file' variables you changed to only have 'file', or you really fixing a problem?

[Gustavo Sverzut Barbieri]

(In reply to comment #2)
> (From update of attachment 61957 [details])
> 
> > +        Keep a pointer to theme filename and check for it correctly.
> 
> What was wrong previously? from what I understood, instead of having 'theme' and 'file' variables you changed to only have 'file', or you really fixing a problem?

The good old annoyance of storing "const char*" that is return of a dynamically allocated String::utf8().data(). Now it is being stored in CString and used as CString::data(), for immediate use, retaining the memory.

[Lucas De Marchi]

(In reply to comment #2)
> (From update of attachment 61957 [details])
> 
> > +        Keep a pointer to theme filename and check for it correctly.
> 
> What was wrong previously? from what I understood, instead of having 'theme' and 'file' variables you changed to only have 'file', or you really fixing a problem?

He was fixing a problem:

> - file = edjeThemeRecursive().utf8().data();

The object returned by .utf8() will die as soon as .data() is returned. Thus 'file' will point for a memory area that is not allocated anymore.

[WebKit Commit Bot]

Comment on attachment 61957 [details]
Patch

Clearing flags on attachment: 61957

Committed r63666: <http://trac.webkit.org/changeset/63666>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.