Bug 42568 - [Chromium] Fix style errors of RenderThemeChromiumWin.cpp
Summary: [Chromium] Fix style errors of RenderThemeChromiumWin.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 08:04 PDT by Kent Tamura
Modified: 2010-07-19 21:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.18 KB, patch)
2010-07-19 08:04 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch (10.54 KB, patch)
2010-07-19 08:08 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-07-19 08:04:07 PDT 
[Chromium] Fix style errors of RenderThemeChromiumWin.cpp
Comment 1 Kent Tamura 2010-07-19 08:04:26 PDT 
Created attachment 61954 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-19 08:05:20 PDT 
Attachment 61954 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/RenderThemeChromiumWin.cpp:192:  Use 0 instead of NULL.  [readability/null] [4]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kent Tamura 2010-07-19 08:08:25 PDT 
Created attachment 61955 [details]
Patch
Comment 4 WebKit Review Bot 2010-07-19 08:10:13 PDT 
Attachment 61955 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/RenderThemeChromiumWin.cpp:192:  Use 0 instead of NULL.  [readability/null] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Shinichiro Hamaji 2010-07-19 08:47:48 PDT 
Comment on attachment 61955 [details]
Patch

Looks good. We need to fix Bug 34605 though.
Comment 6 Kent Tamura 2010-07-19 21:33:59 PDT 
Comment on attachment 61955 [details]
Patch

Clearing flags on attachment: 61955

Committed r63718: <http://trac.webkit.org/changeset/63718>
Comment 7 Kent Tamura 2010-07-19 21:34:08 PDT 
All reviewed patches have been landed.  Closing bug.