Bug 42558 – Web Inspector: hide "toggle debugger" button when debugger is always enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Web Inspector: hide "toggle debugger" button when debugger is always enabled.

[Yury Semikhatsky]

Created attachment 61939 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 61939 [details]
Patch

Clearing flags on attachment: 61939

Committed r63649: <http://trac.webkit.org/changeset/63649>

[Yury Semikhatsky]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

So, now how can the user turn the debugger off? Is it lazy initialized so that
it is inactive until the user visits the Scripts panel? I don't like this change
unless there is something I am missing.

[Pavel Feldman]

(In reply to comment #4)
> So, now how can the user turn the debugger off? Is it lazy initialized so that
> it is inactive until the user visits the Scripts panel? I don't like this change
> unless there is something I am missing.

This is not affecting WebKit/JSC. This was a regression on Chromium side that had  debugger enabled for all times. We've lost this little diverging bit of UI while aligning with the upstream inspector code.

[Joseph Pecoraro]

Ahh, I see. Thanks for the explanation.

[Patrick Mueller]

(In reply to comment #4)
> So, now how can the user turn the debugger off? Is it lazy initialized so that
> it is inactive until the user visits the Scripts panel? I don't like this change
> unless there is something I am missing.

I had the same conversation on IRC a little earlier.  :-)

I think this would have been clearer if instead of

    Preferences.debuggerAlwaysEnabled

it had been something like:

   Platform.debuggerAlwaysEnabled

In this case, the "debuggerAlwaysEnabled" isn't really a "preference", it's a static state of the platform, or something.  Always true for V8, always false for JSC, at least at that point in the code.  If you just went by the name alone, you'd guess, as I and probably Joe did, that this was the state associated with the radio button in the "enable script debugging" panel.

A comment would have also made this clear.