Bug 42558 - Web Inspector: hide "toggle debugger" button when debugger is always enabled
Summary: Web Inspector: hide "toggle debugger" button when debugger is always enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-19 05:03 PDT by Yury Semikhatsky
Modified: 2010-07-19 10:41 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2010-07-19 05:05 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-07-19 05:03:43 PDT 
Web Inspector: hide "toggle debugger" button when debugger is always enabled.
Comment 1 Yury Semikhatsky 2010-07-19 05:05:16 PDT 
Created attachment 61939 [details]
Patch
Comment 2 Yury Semikhatsky 2010-07-19 05:17:50 PDT 
Comment on attachment 61939 [details]
Patch

Clearing flags on attachment: 61939

Committed r63649: <http://trac.webkit.org/changeset/63649>
Comment 3 Yury Semikhatsky 2010-07-19 05:18:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Joseph Pecoraro 2010-07-19 09:48:43 PDT 
So, now how can the user turn the debugger off? Is it lazy initialized so that
it is inactive until the user visits the Scripts panel? I don't like this change
unless there is something I am missing.
Comment 5 Pavel Feldman 2010-07-19 09:50:54 PDT 
(In reply to comment #4)
> So, now how can the user turn the debugger off? Is it lazy initialized so that
> it is inactive until the user visits the Scripts panel? I don't like this change
> unless there is something I am missing.

This is not affecting WebKit/JSC. This was a regression on Chromium side that had  debugger enabled for all times. We've lost this little diverging bit of UI while aligning with the upstream inspector code.
Comment 6 Joseph Pecoraro 2010-07-19 09:54:28 PDT 
Ahh, I see. Thanks for the explanation.
Comment 7 Patrick Mueller 2010-07-19 10:41:49 PDT 
(In reply to comment #4)
> So, now how can the user turn the debugger off? Is it lazy initialized so that
> it is inactive until the user visits the Scripts panel? I don't like this change
> unless there is something I am missing.

I had the same conversation on IRC a little earlier.  :-)

I think this would have been clearer if instead of

    Preferences.debuggerAlwaysEnabled

it had been something like:

   Platform.debuggerAlwaysEnabled

In this case, the "debuggerAlwaysEnabled" isn't really a "preference", it's a static state of the platform, or something.  Always true for V8, always false for JSC, at least at that point in the code.  If you just went by the name alone, you'd guess, as I and probably Joe did, that this was the state associated with the radio button in the "enable script debugging" panel.

A comment would have also made this clear.