Bug 42523 – Web Inspector: the bindings generation helper script can be simplified a bit. Chromium.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

rule_binding.py does move operation for header files generated by CodeGeneratorV8.
It is a bit strange because its much easier to generate headers in the right folder by CodeGenerator itself.

[Ilya Tikhonovsky]

Created attachment 61909 [details]
[patch] initial version.

[Pavel Feldman]

Comment on attachment 61909 [details]
[patch] initial version.

A bunch of nits to fix.

WebCore/WebCore.gyp/scripts/rule_binding.py:124
 +      command.extend(['--outputHDir', hdir])
Here and below outputHeadersDir

WebCore/WebCore.gyp/scripts/rule_binding.py: 
 +      # Both the .cpp and .h were generated in cppdir, but if hdir is different,
Can you avoid changing this behavior?

WebCore/bindings/scripts/CodeGenerator.pm:112
 +      $codeGenerator = $ifaceName->new($object, $useOutputDir, $useLayerOnTop, $preprocessor, $writeDependencies, $verbose, $useOutputHDir);
I'd keep useOutputDir and useOutputHeadersDir next to each other.

WebCore/inspector/CodeGeneratorInspector.pm:282
 +      open(my $HEADER, ">$outputHDir/$frontendClassName.h") || die "Couldn't open file $outputDir/$frontendClassName.h";
print HeadersDir, not Dir in the message.

[Ilya Tikhonovsky]

Created attachment 61912 [details]
[patch] second iteration

[Yury Semikhatsky]

Comment on attachment 61912 [details]
[patch] second iteration

WebCore/ChangeLog:5
 +          WebInspector: Web Inspector: the bindings generation helper script can be
WebInspector: Web Inspector: ->  Web Inspector:

[WebKit Review Bot]

http://trac.webkit.org/changeset/63764 might have broken Chromium Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63761
http://trac.webkit.org/changeset/63764

[Ilya Tikhonovsky]

Committed r63803
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gyp/WebCore.gyp
	M	WebCore/WebCore.gyp/scripts/rule_binding.py
	M	WebCore/bindings/scripts/CodeGeneratorCPP.pm
	M	WebCore/bindings/scripts/generate-bindings.pl
	M	WebCore/bindings/scripts/CodeGeneratorJS.pm
	M	WebCore/bindings/scripts/CodeGeneratorObjC.pm
	M	WebCore/bindings/scripts/CodeGeneratorV8.pm
	M	WebCore/bindings/scripts/CodeGenerator.pm
	M	WebCore/inspector/CodeGeneratorInspector.pm
r63803 = f77b355757ca7fcdb5f175d980dca7784f35debc (refs/remotes/trunk)