Bug 42516 - Add dumping of statusbar text to WebKitTestRunner
Summary: Add dumping of statusbar text to WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-18 09:40 PDT by Anders Carlsson
Modified: 2010-07-18 10:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.97 KB, patch)
2010-07-18 09:44 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-18 09:40:16 PDT 
Add dumping of statusbar text to WebKitTestRunner
Comment 1 Anders Carlsson 2010-07-18 09:44:44 PDT 
Created attachment 61902 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-18 09:45:30 PDT 
Attachment 61902 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:70:  Extra space between WKBundlePageSetStatusbarTextCallback and setStatusbarText  [whitespace/declaration] [3]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:64:  _setStatusbarText is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:202:  InjectedBundlePage::_setStatusbarText is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2010-07-18 09:51:47 PDT 
Comment on attachment 61902 [details]
Patch

>  typedef void (*WKBundlePageAddMessageToConsoleCallback)(WKBundlePageRef page, WKStringRef message, uint32_t lineNumber, const void *clientInfo);

Star on the wrong side of the space here.

> +typedef void (*WKBundlePageSetStatusbarTextCallback)(WKBundlePageRef page, WKStringRef statusbarText, const void *clientInfo);

and here

>      const void *                                                        clientInfo;

and here

> +void InjectedBundlePage::_setStatusbarText(WKBundlePageRef page, WKStringRef statusbarText, const void *clientInfo)

and here

>      static void _addMessageToConsole(WKBundlePageRef page, WKStringRef message, uint32_t lineNumber, const void *clientInfo);

and here

> +    static void _setStatusbarText(WKBundlePageRef page, WKStringRef statusbarText, const void *clientInfo);

and here

r=me if you fix the style issues.
Comment 4 mitz 2010-07-18 09:59:52 PDT 
(In reply to comment #3)
> (From update of attachment 61902 [details])
> >  typedef void (*WKBundlePageAddMessageToConsoleCallback)(WKBundlePageRef page, WKStringRef message, uint32_t lineNumber, const void *clientInfo);
> 
> Star on the wrong side of the space here.

I was wrong. CF-style is that the space comes before the star. r=me then.
Comment 5 Anders Carlsson 2010-07-18 10:03:17 PDT 
Committed r63627: <http://trac.webkit.org/changeset/63627>