Bug 42512 – [Web Timing] Move times to DocumentLoader and fix bugs in mark points

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Gentilcore]

[Web Timing] Move times to DocumentLoader and fix bugs in mark points

[Tony Gentilcore]

Created attachment 61906 [details]
Patch

[Tony Gentilcore]

I believe this fixes the last of the critical web timing bugs. Sorry for the big patch, but maybe its actually good to review all of the marks in one place.

[Darin Fisher (:fishd, Google)]

Comment on attachment 61906 [details]
Patch

WebCore/loader/DocumentLoader.h:208
 +          DocumentLoadTiming* documentLoadTiming() { return &m_documentLoadTiming; }
one minor suggestion: you could probably get away with shortening this member
function to "timing()" as the "documentLoad" prefix is sort of redundant with the
name of the class, DocumentLoader.

R=me

[Tony Gentilcore]

(In reply to comment #3)
> (From update of attachment 61906 [details])
> WebCore/loader/DocumentLoader.h:208
>  +          DocumentLoadTiming* documentLoadTiming() { return &m_documentLoadTiming; }
> one minor suggestion: you could probably get away with shortening this member
> function to "timing()" as the "documentLoad" prefix is sort of redundant with the
> name of the class, DocumentLoader.

Thanks!

Fixed and landing.

> 
> R=me

[Tony Gentilcore]

Committed r63689: <http://trac.webkit.org/changeset/63689>