Bug 42512 - [Web Timing] Move times to DocumentLoader and fix bugs in mark points
Summary: [Web Timing] Move times to DocumentLoader and fix bugs in mark points
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 30685
  Show dependency treegraph
 
Reported: 2010-07-17 21:46 PDT by Tony Gentilcore
Modified: 2010-07-19 14:56 PDT (History)
2 users (show)

See Also:


Attachments
Patch (30.14 KB, patch)
2010-07-18 12:14 PDT, Tony Gentilcore
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-07-17 21:46:08 PDT
[Web Timing] Move times to DocumentLoader and fix bugs in mark points
Comment 1 Tony Gentilcore 2010-07-18 12:14:00 PDT
Created attachment 61906 [details]
Patch
Comment 2 Tony Gentilcore 2010-07-18 12:25:25 PDT
I believe this fixes the last of the critical web timing bugs. Sorry for the big patch, but maybe its actually good to review all of the marks in one place.
Comment 3 Darin Fisher (:fishd, Google) 2010-07-19 13:50:20 PDT
Comment on attachment 61906 [details]
Patch

WebCore/loader/DocumentLoader.h:208
 +          DocumentLoadTiming* documentLoadTiming() { return &m_documentLoadTiming; }
one minor suggestion: you could probably get away with shortening this member
function to "timing()" as the "documentLoad" prefix is sort of redundant with the
name of the class, DocumentLoader.

R=me
Comment 4 Tony Gentilcore 2010-07-19 14:18:00 PDT
(In reply to comment #3)
> (From update of attachment 61906 [details])
> WebCore/loader/DocumentLoader.h:208
>  +          DocumentLoadTiming* documentLoadTiming() { return &m_documentLoadTiming; }
> one minor suggestion: you could probably get away with shortening this member
> function to "timing()" as the "documentLoad" prefix is sort of redundant with the
> name of the class, DocumentLoader.

Thanks!

Fixed and landing.

> 
> R=me
Comment 5 Tony Gentilcore 2010-07-19 14:56:11 PDT
Committed r63689: <http://trac.webkit.org/changeset/63689>