Bug 42500 – HTMLLinkElement ignores dnsPrefetchingEnabled setting

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Jeff Johnson]

A setting to disable DNS prefetching was landed in svn r62284:

http://trac.webkit.org/changeset/62284/trunk

DNS prefetching is done by the ResourceHandle::prepareForURL() function. Most calls to prepareForURL() are protected by a check of whether DNS prefetching is enabled. However, HTMLLinkElement does not perform such a check:

https://trac.webkit.org/browser/trunk/WebCore/html/HTMLLinkElement.cpp

193    if (m_relAttribute.m_isDNSPrefetch && m_url.isValid() && !m_url.isEmpty())
194        ResourceHandle::prepareForURL(m_url);

A check should be added here to make sure DNS prefetching is enabled before triggering DNS prefetching.

[Daniel Bates]

It doesn't seem correct to override the WebKit setting for the HTML Link element.

Created attachment 61892 [details]
patch

[WebKit Review Bot]

Attachment 61892 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:19:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 8 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Timothy Hatcher]

Comment on attachment 61892 [details]
patch

r- for tabs.

Created attachment 61893 [details]
patch

[WebKit Commit Bot]

Comment on attachment 61893 [details]
patch

Clearing flags on attachment: 61893

Committed r63622: <http://trac.webkit.org/changeset/63622>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

<rdar://problem/8290265>

[Alexey Proskuryakov]

See bug 48813.