Bug 42471 - ES5 allows use of reserved words as IdentifierName
Summary: ES5 allows use of reserved words as IdentifierName
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
: 32721 32722 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-16 11:03 PDT by Oliver Hunt
Modified: 2012-07-07 10:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (36.22 KB, patch)
2010-07-16 11:17 PDT, Oliver Hunt 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-07-16 11:03:20 PDT 
ES5 allows use of reserved words as IdentifierName
Comment 1 Zoltan Herczeg 2010-07-16 11:05:14 PDT 
Interesting. Example?
Comment 2 Oliver Hunt 2010-07-16 11:17:08 PDT 
Created attachment 61829 [details]
Patch
Comment 3 Oliver Hunt 2010-07-16 11:18:13 PDT 
(In reply to comment #1)
> Interesting. Example?

a.var = 5;
a={var:5}
Comment 4 Geoffrey Garen 2010-07-16 11:20:44 PDT 
Comment on attachment 61829 [details]
Patch

r=me
Comment 5 Zoltan Herczeg 2010-07-16 11:35:39 PDT 
*** Bug 32722 has been marked as a duplicate of this bug. ***
Comment 6 Joseph Pecoraro 2010-07-16 12:32:12 PDT 
Thanks for duping Zoltan, and great to see this was fixed Oliver!

I notice Oliver's changelog says "These tests are wrong, unsure how
to get sputnik tests corrected." Were they wrong for ES3, or just
wrong for ES5? It would be nice to have a list of the tests in sputnik
that are expected to fail going from ES3 to ES5.
Comment 7 Oliver Hunt 2010-07-16 12:38:00 PDT 
(In reply to comment #6)
> Thanks for duping Zoltan, and great to see this was fixed Oliver!
> 
> I notice Oliver's changelog says "These tests are wrong, unsure how
> to get sputnik tests corrected." Were they wrong for ES3, or just
> wrong for ES5? It would be nice to have a list of the tests in sputnik
> that are expected to fail going from ES3 to ES5.

Sputnik is (afaict) intended to be an ES5 test suite based on other tests.
Comment 8 Adam Barth 2010-08-10 22:36:28 PDT 
Comment on attachment 61829 [details]
Patch

Is this patch still current?
Comment 9 Zoltan Herczeg 2010-08-11 00:14:30 PDT 
Maybe http://trac.webkit.org/changeset/63566 ?

I close this bug.
Comment 10 Jeff Walden (remove +bwo to email) 2011-01-24 07:32:52 PST 
*** Bug 32721 has been marked as a duplicate of this bug. ***