RESOLVED FIXED 42471
ES5 allows use of reserved words as IdentifierName 
https://bugs.webkit.org/show_bug.cgi?id=42471
Summary ES5 allows use of reserved words as IdentifierName
Oliver Hunt
Reported 2010-07-16 11:03:20 PDT
ES5 allows use of reserved words as IdentifierName
Attachments
Patch (36.22 KB, patch)
2010-07-16 11:17 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Herczeg
Comment 1 2010-07-16 11:05:14 PDT
Interesting. Example?
Oliver Hunt
Comment 2 2010-07-16 11:17:08 PDT
Created attachment 61829 [details] Patch
Oliver Hunt
Comment 3 2010-07-16 11:18:13 PDT
(In reply to comment #1) > Interesting. Example? a.var = 5; a={var:5}
Geoffrey Garen
Comment 4 2010-07-16 11:20:44 PDT
Comment on attachment 61829 [details] Patch r=me
Zoltan Herczeg
Comment 5 2010-07-16 11:35:39 PDT
*** Bug 32722 has been marked as a duplicate of this bug. ***
Joseph Pecoraro
Comment 6 2010-07-16 12:32:12 PDT
Thanks for duping Zoltan, and great to see this was fixed Oliver! I notice Oliver's changelog says "These tests are wrong, unsure how to get sputnik tests corrected." Were they wrong for ES3, or just wrong for ES5? It would be nice to have a list of the tests in sputnik that are expected to fail going from ES3 to ES5.
Oliver Hunt
Comment 7 2010-07-16 12:38:00 PDT
(In reply to comment #6) > Thanks for duping Zoltan, and great to see this was fixed Oliver! > > I notice Oliver's changelog says "These tests are wrong, unsure how > to get sputnik tests corrected." Were they wrong for ES3, or just > wrong for ES5? It would be nice to have a list of the tests in sputnik > that are expected to fail going from ES3 to ES5. Sputnik is (afaict) intended to be an ES5 test suite based on other tests.
Adam Barth
Comment 8 2010-08-10 22:36:28 PDT
Comment on attachment 61829 [details] Patch Is this patch still current?
Zoltan Herczeg
Comment 9 2010-08-11 00:14:30 PDT
Maybe http://trac.webkit.org/changeset/63566 ? I close this bug.
Jeff Walden (remove +bwo to email)
Comment 10 2011-01-24 07:32:52 PST
*** Bug 32721 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.