Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file
Created attachment 61821 [details] Patch
Comment on attachment 61821 [details] Patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 4558db60cf53f1b2d7bdc4fddb487c8516f91d66..079c9321a32ab8ba68b3b37fb35ed13fade0533a 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,21 @@ > +2010-07-16 Hans Wennborg <hans@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file > + https://bugs.webkit.org/show_bug.cgi?id=42466 > + > + This avoids needing to have the full declaration of DeviceOrientation > + in DeviceOrientationEvent.h, which was otherwise necessary because > + of the implicit destructor. Consider moving this comment (and shortening) to be where the function is listed in the ChangeLog. > + (Original problem at https://bugs.webkit.org/show_bug.cgi?id=42447) > + > + No new tests. (OOPS!) This should be removed -- perhaps replaced by "No new functionality so no new tests.". > + > + * dom/DeviceOrientationEvent.cpp: > + (WebCore::DeviceOrientationEvent::~DeviceOrientationEvent): Right here. Something like: "Move here to voids needing to have the full declaration of DeviceOrientation in DeviceOrientationEvent.h" > + * dom/DeviceOrientationEvent.h: r- due to OOPS for no new tests (as this won't auto-commit).
Created attachment 61884 [details] Patch
Comment on attachment 61884 [details] Patch r=me
Comment on attachment 61884 [details] Patch Clearing flags on attachment: 61884 Committed r63646: <http://trac.webkit.org/changeset/63646>
All reviewed patches have been landed. Closing bug.