%subj% The current implementation of generator is not ready for generation Backend part of Inspector interface. The full patch with Backend is quite big and I've split it.
Created attachment 61816 [details] [patch] initial version.
Comment on attachment 61816 [details] [patch] initial version. WebCore/inspector/CodeGeneratorInspector.pm:40 + }; Maybe accessorSuffix to be more specific? WebCore/inspector/CodeGeneratorInspector.pm:104 + my $callId = new domSignature(); domSignature sounds weird to me WebCore/inspector/CodeGeneratorInspector.pm:176 + my @argsFiltered = grep($_->direction eq "out", @{$function->parameters}); Some comment would clarify this stuff.
(In reply to comment #2) > (From update of attachment 61816 [details]) > WebCore/inspector/CodeGeneratorInspector.pm:40 > + }; > Maybe accessorSuffix to be more specific? For now I like "pushSuffix". Its the method used to push the result into an InspectorValue. But, it may also be used later for pulling out of an InspectorValue, when generating a dispatch function. If so I don't know whats best, accessorSuffix may be good enough.
Committed r63561 M WebCore/ChangeLog M WebCore/inspector/CodeGeneratorInspector.pm M WebCore/inspector/InspectorValues.h M WebCore/inspector/Inspector.idl M WebCore/inspector/InspectorValues.cpp r63561 = 52486558854a03d87a6292b1d1bc050243e0e37c (refs/remotes/trunk)
http://trac.webkit.org/changeset/63561 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/63561 http://trac.webkit.org/changeset/63562 http://trac.webkit.org/changeset/63563