RESOLVED FIXED 42452
Web Inspector: show actual breakpoint position in UI. 
https://bugs.webkit.org/show_bug.cgi?id=42452
Summary Web Inspector: show actual breakpoint position in UI.
Pavel Podivilov
Reported 2010-07-16 06:39:34 PDT
Web Inspector: show actual breakpoint position in UI.
Attachments
Proposed patch. (1.24 KB, patch)
2010-07-16 06:42 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-07-16 06:42:02 PDT
Created attachment 61801 [details] Proposed patch.
Pavel Feldman
Comment 2 2010-07-17 04:48:36 PDT
Comment on attachment 61801 [details] Proposed patch. WebKit/chromium/src/js/DebuggerScript.js:102 + return undefined; What will the user see in the UI when setting breakpoint on a comment? Does it simply vanish?
Pavel Feldman
Comment 3 2010-07-18 09:32:33 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/src/js/DebuggerScript.js Committed r63626
Pavel Podivilov
Comment 4 2010-07-19 02:21:04 PDT
(In reply to comment #2) > (From update of attachment 61801 [details]) > WebKit/chromium/src/js/DebuggerScript.js:102 > + return undefined; > What will the user see in the UI when setting breakpoint on a comment? Does it simply vanish? It will be set on nearest statement by v8 debugger. Here we got undefined only when trying to set a breakpoint outside a script.
Note You need to log in before you can comment on or make changes to this bug.