Bug 42444 - [GTK] new media tests baselines needed
Summary: [GTK] new media tests baselines needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-16 03:21 PDT by Philippe Normand
Modified: 2010-08-12 01:25 PDT (History)
0 users

See Also:


Attachments
proposed patch (16.69 KB, patch)
2010-07-16 04:21 PDT, Philippe Normand
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-07-16 03:21:53 PDT
media/audio-controls-rendering.html -> new
media/audio-no-installed-engines.html -> new
media/video-aspect-ratio.html -> new
media/video-display-toggle.html -> new
media/video-empty-source.html -> new
media/video-layer-crash.html -> new
media/video-no-audio.html -> new
media/video-transformed.html -> new
media/video-volume-slider.html -> new
media/video-zoom-controls.html -> new
media/video-zoom.html -> new

I will check those, compare with results from other platforms and send a patch :)
Comment 1 Philippe Normand 2010-07-16 04:21:25 PDT
Created attachment 61792 [details]
proposed patch
Comment 2 Philippe Normand 2010-07-16 04:23:59 PDT
media/video-volume-slider.html -> new

needs the volume slider indeed, so I don't add its baseline.

media/video-aspect-ratio.html -> new

I think we fail on that test. The smaller videos are displayed but they have inegal sizes and they don't seem to be 1/4 of the original video size.
Comment 3 Martin Robinson 2010-08-11 15:59:44 PDT
Comment on attachment 61792 [details]
proposed patch

LGTM, but you do not need a review to add or correct test baselines. :)
Comment 4 Philippe Normand 2010-08-12 01:25:25 PDT
Landed in http://trac.webkit.org/changeset/65224
Thanks!