WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
42444
[GTK] new media tests baselines needed
https://bugs.webkit.org/show_bug.cgi?id=42444
Summary
[GTK] new media tests baselines needed
Philippe Normand
Reported
2010-07-16 03:21:53 PDT
media/audio-controls-rendering.html -> new media/audio-no-installed-engines.html -> new media/video-aspect-ratio.html -> new media/video-display-toggle.html -> new media/video-empty-source.html -> new media/video-layer-crash.html -> new media/video-no-audio.html -> new media/video-transformed.html -> new media/video-volume-slider.html -> new media/video-zoom-controls.html -> new media/video-zoom.html -> new I will check those, compare with results from other platforms and send a patch :)
Attachments
proposed patch
(16.69 KB, patch)
2010-07-16 04:21 PDT
,
Philippe Normand
mrobinson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2010-07-16 04:21:25 PDT
Created
attachment 61792
[details]
proposed patch
Philippe Normand
Comment 2
2010-07-16 04:23:59 PDT
media/video-volume-slider.html -> new needs the volume slider indeed, so I don't add its baseline. media/video-aspect-ratio.html -> new I think we fail on that test. The smaller videos are displayed but they have inegal sizes and they don't seem to be 1/4 of the original video size.
Martin Robinson
Comment 3
2010-08-11 15:59:44 PDT
Comment on
attachment 61792
[details]
proposed patch LGTM, but you do not need a review to add or correct test baselines. :)
Philippe Normand
Comment 4
2010-08-12 01:25:25 PDT
Landed in
http://trac.webkit.org/changeset/65224
Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug