RESOLVED FIXED 42439
WebSocket: Put echo-challenge_wsh.py under workers/resources directory 
https://bugs.webkit.org/show_bug.cgi?id=42439
Summary WebSocket: Put echo-challenge_wsh.py under workers/resources directory
Yuta Kitamura
Reported 2010-07-15 22:19:53 PDT
Currently, websocket/tests/workers/worker-handshake-challenge-randomness.html depends on websocket/tests/echo-challenge_wsh.py. This configuration is not desirable for Chromium's worker test which only copies the content under workers/resources directory when running WebSocket worker tests.
Attachments
Patch (2.50 KB, patch)
2010-07-15 22:35 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2010-07-15 22:35:42 PDT
Created attachment 61767 [details] Patch
Fumitoshi Ukai
Comment 2 2010-07-15 22:38:54 PDT
Looks good
Kent Tamura
Comment 3 2010-07-15 22:45:02 PDT
Comment on attachment 61767 [details] Patch OK.
WebKit Commit Bot
Comment 4 2010-07-15 23:34:36 PDT
Comment on attachment 61767 [details] Patch Clearing flags on attachment: 61767 Committed r63524: <http://trac.webkit.org/changeset/63524>
WebKit Commit Bot
Comment 5 2010-07-15 23:34:40 PDT
All reviewed patches have been landed. Closing bug.
Yuta Kitamura
Comment 7 2010-07-16 00:12:03 PDT
(In reply to comment #6) > http://trac.webkit.org/changeset/63524 might have broken Tiger Intel Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/63521 > http://trac.webkit.org/changeset/63522 > http://trac.webkit.org/changeset/63523 > http://trac.webkit.org/changeset/63524 > http://trac.webkit.org/changeset/63525 This alarm seems irrelevant to this patch.
Alexey Proskuryakov
Comment 8 2010-07-16 10:54:51 PDT
I think that longer term, we need a better solution. Almost every feature of main document WebSocket should be also tested in workers - are we really going to have two copies of every script?
Note You need to log in before you can comment on or make changes to this bug.