Bug 42438 - Add directional property enums to the switch in applyProperty
Summary: Add directional property enums to the switch in applyProperty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-15 19:42 PDT by Erik Arvidsson
Modified: 2010-07-15 20:03 PDT (History)
0 users

See Also:


Attachments
Patch (2.24 KB, patch)
2010-07-15 19:44 PDT, Erik Arvidsson
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2010-07-15 19:42:49 PDT
Add directional property enums to the switch in applyProperty
Comment 1 Erik Arvidsson 2010-07-15 19:44:10 PDT
Created attachment 61758 [details]
Patch
Comment 2 David Levin 2010-07-15 19:55:46 PDT
Comment on attachment 61758 [details]
Patch

I wish there was a "cleaner" way of doing it. (In fact, I can think of one but it involves macros and perhaps a little trickiness so maybe it wouldn't be that great.)


Here's the shape of what I'm thinking of. A "header" file with a list like this.
  CSS_DIRECTION_AWARE_PROPERTY(CSSPropertyWebkitMarginEnd, CSSPropertyMarginRight, CSSPropertyMarginLeft)

Anyway what you have here will work.
Comment 3 Erik Arvidsson 2010-07-15 20:03:01 PDT
Committed r63509: <http://trac.webkit.org/changeset/63509>