RESOLVED FIXED 42438
Add directional property enums to the switch in applyProperty 
https://bugs.webkit.org/show_bug.cgi?id=42438
Summary Add directional property enums to the switch in applyProperty
Erik Arvidsson
Reported 2010-07-15 19:42:49 PDT
Add directional property enums to the switch in applyProperty
Attachments
Patch (2.24 KB, patch)
2010-07-15 19:44 PDT, Erik Arvidsson 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2010-07-15 19:44:10 PDT
Created attachment 61758 [details] Patch
David Levin
Comment 2 2010-07-15 19:55:46 PDT
Comment on attachment 61758 [details] Patch I wish there was a "cleaner" way of doing it. (In fact, I can think of one but it involves macros and perhaps a little trickiness so maybe it wouldn't be that great.) Here's the shape of what I'm thinking of. A "header" file with a list like this. CSS_DIRECTION_AWARE_PROPERTY(CSSPropertyWebkitMarginEnd, CSSPropertyMarginRight, CSSPropertyMarginLeft) Anyway what you have here will work.
Erik Arvidsson
Comment 3 2010-07-15 20:03:01 PDT
Committed r63509: <http://trac.webkit.org/changeset/63509>
Note You need to log in before you can comment on or make changes to this bug.