Bug 42409 - Incorporate tests for CheckedInt.h
Summary: Incorporate tests for CheckedInt.h
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 41473
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-15 14:36 PDT by Kenneth Russell
Modified: 2010-08-08 14:12 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-07-15 14:36:46 PDT
Benoit Jacob at Mozilla points out in the comments for https://bugs.webkit.org/show_bug.cgi?id=41473 that there are some good unit tests for the CheckedInt class incorporated in that patch ( http://hg.mozilla.org/mozilla-central/file/tip/xpcom/tests/TestCheckedInt.cpp ) which should be added. A reasonable initial location for them would be WebKit/chromium/tests/.
Comment 1 Benoit Jacob 2010-08-08 14:12:10 PDT
By the way, a couple of minor updates have been made to CheckedInt upstream. Nothing very big but you might still pick them up together with the unit test. Some documentation fixes, and also avoiding relying certain signed integer bit-shift operations that are left undefined by the c++ standard (even though that hasn't been a problem in practice, and the test suite is complete enough to catch any such issue on a given platform).