Bug 42401 - Query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by WebGL
Summary: Query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by WebGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-15 13:47 PDT by Kenneth Russell
Modified: 2010-07-15 14:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.80 KB, patch)
2010-07-15 13:55 PDT, Kenneth Russell 		japhet: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-07-15 13:47:59 PDT 
The query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by the WebGL implementation rather than delegating to the underlying OpenGL API, because WebGL 1.0 does not support compressed textures and must return 0 for this query.
Comment 1 Kenneth Russell 2010-07-15 13:55:40 PDT 
Created attachment 61715 [details]
Patch
Comment 2 Nate Chapin 2010-07-15 14:02:23 PDT 
Comment on attachment 61715 [details]
Patch

Per offline conversation, please add a comment explaining why we're hard-coding a 0 before submitting.

>      case GraphicsContext3D::NUM_COMPRESSED_TEXTURE_FORMATS:
> -        return getLongParameter(pname);
> +        return WebGLGetInfo(static_cast<long>(0));
Comment 3 Kenneth Russell 2010-07-15 14:05:50 PDT 
Committed r63460: <http://trac.webkit.org/changeset/63460>