Bug 42389 - Add leakRef and clear to all RefPtr variants
Summary: Add leakRef and clear to all RefPtr variants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-15 11:29 PDT by Darin Adler
Modified: 2010-08-11 00:08 PDT (History)
2 users (show)

See Also:


Attachments
Patch (39.34 KB, patch)
2010-07-15 11:49 PDT, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-07-15 11:29:17 PDT
Add leakRef and clear to all RefPtr variants
Comment 1 Darin Adler 2010-07-15 11:49:03 PDT
Created attachment 61697 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-15 19:07:40 PDT
Attachment 61697 [details] did not build on win:
Build output: http://webkit-commit-queue.appspot.com/results/3401449
Comment 3 Adam Barth 2010-08-06 20:10:32 PDT
Darin, did you want to land this patch?
Comment 4 Darin Adler 2010-08-08 17:41:49 PDT
Yes, I am planning to and have not had time to yet.
Comment 5 Adam Barth 2010-08-08 18:28:03 PDT
I'd be happy to do it for you if you'd rather spend that time reviewing patches.  :)
Comment 6 Darin Adler 2010-08-08 21:40:14 PDT
If you want to land it, that would be fine with me. But there may be merging necessary due to changes related to WARN_UNUSED_RETURN.
Comment 7 Adam Barth 2010-08-10 23:17:18 PDT
I have a merged version locally.  Attempting to land.
Comment 8 Adam Barth 2010-08-11 00:08:41 PDT
Committed r65130: <http://trac.webkit.org/changeset/65130>