Bug 42385 - [chromium] WebViewClient::removeAutofillSuggestions is not passed the correct name
Summary: [chromium] WebViewClient::removeAutofillSuggestions is not passed the correct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Scott Violet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-15 09:57 PDT by Scott Violet
Modified: 2010-07-15 16:31 PDT (History)
2 users (show)

See Also:

Attachments
Initial fix (1.59 KB, patch)
2010-07-15 10:01 PDT, Scott Violet 		no flags Details | Formatted Diff | Diff
Incorporates review feedback (1.70 KB, patch)
2010-07-15 10:31 PDT, Scott Violet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Violet 2010-07-15 09:57:33 PDT 
removeAutofillSuggestions is not always passed the correct name of the entry to remove.
Comment 1 Scott Violet 2010-07-15 10:01:10 PDT 
Created attachment 61681 [details]
Initial fix
Comment 2 David Holloway 2010-07-15 10:20:38 PDT 
LGTM.

One small style question.  Might it be slightly cleaner to dispense with the temporary variable?  I.e.:
WebInputElement(static_cast<HTMLInputElement*>(element)).nameForAutofill();
Comment 3 Scott Violet 2010-07-15 10:31:43 PDT 
Created attachment 61684 [details]
Incorporates review feedback
Comment 4 David Holloway 2010-07-15 10:39:34 PDT 
SLGTM.
Comment 5 WebKit Commit Bot 2010-07-15 16:31:28 PDT 
Comment on attachment 61684 [details]
Incorporates review feedback

Clearing flags on attachment: 61684

Committed r63489: <http://trac.webkit.org/changeset/63489>
Comment 6 WebKit Commit Bot 2010-07-15 16:31:35 PDT 
All reviewed patches have been landed.  Closing bug.