Send JavaScript stream data to plug-ins
Created attachment 61675 [details] Patch
Attachment 61675 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:65: NPP_WriteReady is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:66: NPP_Write is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:161: NetscapePlugin::NPP_WriteReady is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:166: NetscapePlugin::NPP_Write is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 61675 [details] Patch > +void NetscapePluginStream::deliverData(const char* bytes, int length) int? int32_t? unsigned? uint32_t? size_t? Our seemingly random length types drive me crazy! Does this already have layout test coverage? r=me
(In reply to comment #3) > (From update of attachment 61675 [details]) > > +void NetscapePluginStream::deliverData(const char* bytes, int length) > > int? int32_t? unsigned? uint32_t? size_t? Our seemingly random length types drive me crazy! > Yeah it's really annoying. I used the same type as ResourceHandleClient::didReceiveData. We should definitly fix didReceiveData and all the clients etc to use a size_t instead. > Does this already have layout test coverage? Yes.
Committed r63439: <http://trac.webkit.org/changeset/63439>