Bug 42376 - svg/dynamic-updates tests are broken - pixel test not generated/compared anymore
Summary: svg/dynamic-updates tests are broken - pixel test not generated/compared anymore
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Critical
Assignee: Nikolas Zimmermann
Depends on: 42374
Blocks: 42615 42616 42617 42618
  Show dependency treegraph
Reported: 2010-07-15 07:55 PDT by Nikolas Zimmermann
Modified: 2010-07-20 00:48 PDT (History)
1 user (show)

See Also:

Patch (deleted)
2010-07-20 00:34 PDT, Nikolas Zimmermann
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-07-15 07:55:41 PDT
Since a while, can't say how long, didn't investigate - DRT doesn't generate pixel test results for tests which have dumpAsText=true set.
With the DRT change in bug 42374, I can reactivate them - and it's already visible that we have regressions *SIGH*.

The svg/dynamic-updates tests want textual results (no render tree dumps) and a pixel test result - w/o pixel tests they're useless, as they are specifically testing dynamic changes of certain attributes/properties + repainting.
Comment 1 Nikolas Zimmermann 2010-07-20 00:34:00 PDT
Created attachment 62038 [details]

Large patch, as it contains the new pixel test baseline for svg/dynamic-updates.
Comment 2 Maciej Stachowiak 2010-07-20 00:43:20 PDT
Comment on attachment 62038 [details]

Comment 3 Nikolas Zimmermann 2010-07-20 00:48:19 PDT
Landed in r63730.