Bug 42372 – Web Inspector: differentiate between blocking and connecting timers.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Also contains couple of drive-by fixes:
- allows setting "cached" after the resource graph has been created.
- prevents inspector from getting information about the same resource twice in case areMemoryCacheClientCallsEnabled == true.

[Pavel Feldman]

Created attachment 61655 [details]
[PATCH] Proposed change.

[Yury Semikhatsky]

Comment on attachment 61655 [details]
[PATCH] Proposed change.

WebCore/loader/FrameLoader.cpp:3080
 +          page->inspectorController()->didLoadResourceFromMemoryCache(m_documentLoader.get(), resource);
You seem to miss this call from the next branch.

WebCore/inspector/InspectorResource.cpp:67
 +      , m_connection(false)
What is this?

[Pavel Feldman]

Created attachment 61657 [details]
[PATCH] Fixed typos, added cached reporting branch.

[Yury Semikhatsky]

Comment on attachment 61657 [details]
[PATCH] Fixed typos, added cached reporting branch.

WebCore/loader/FrameLoader.cpp:3080
 +          page->inspectorController()->didLoadResourceFromMemoryCache(m_documentLoader.get(), resource);
Would be nice if we could get rid of duplicating this call.

[Pavel Feldman]

Created attachment 61659 [details]
[PATCH] To land.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorResource.cpp
	M	WebCore/inspector/InspectorResource.h
	M	WebCore/inspector/front-end/Resource.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/loader/FrameLoader.cpp
	M	WebCore/platform/network/ResourceResponseBase.cpp
	M	WebCore/platform/network/ResourceResponseBase.h
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/public/WebURLResponse.h
	M	WebKit/chromium/src/WebURLResponse.cpp
Committed r63425