Bug 42368 – [Qt] Setting up the Qt WebKit2 binaries - MiniBrowser and QtWebProcess - to build

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

[Balazs Kelemen]

It is time to integrate the MiniBrowser and the QtWebProcess to the build since we already have the environment for the framework.

[Balazs Kelemen]

Created attachment 61677 [details]
proposed patch

The patch has got some ugly part but I ask for review because it is really hard to effectively work on the port without being able to build it on the trunk. Later we should fix those ugliness.

[WebKit Review Bot]

Attachment 61677 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/qt/MainQt.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/qt/MainQt.cpp:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Balazs Kelemen]

Please provide some feedback. I would be happy with even an r- with suggestions :).

[Diego Gonzalez]

(In reply to comment #3)
> Please provide some feedback. I would be happy with even an r- with suggestions :).

Hi :)

I tried your patch but I'm having problems to start QtWebProcess. I have the PATH already set but I can't see the process running. Any tip?

[Balazs Kelemen]

(In reply to comment #4)
> (In reply to comment #3)
> > Please provide some feedback. I would be happy with even an r- with suggestions :).
> 
> Hi :)
> 
> I tried your patch but I'm having problems to start QtWebProcess. I have the PATH already set but I can't see the process running. Any tip?

I have this problem too. Seems like the ProcessLauncher is broken (and smg could be wrong with the coonnection too). Changeset 62790 (http://trac.webkit.org/changeset/62790) would fix the problems with setting up the web process and the connection. That was unreliable before the changeset (one time everything worked well, the other time the connection did not set up) but it seems like - at least on our machines -  that fix does not work (but at least reliably not work :) ) Actually, I have no idea about how was that change tested since we do not have a build system. I am going to investigate in the problem further. However, the target of this patch is to have a complete and buildable qt port of WebKit2 in the trunk, so I do not think that this problem blocks this patch.

[Kenneth Rohde Christiansen]

Comment on attachment 61677 [details]
proposed patch

I would really like this split up into smaller patches for each individual change.

[Balazs Kelemen]

Spliced to 42622 (already landed), 42623, 42638.