Bug 42352 - Text layout is wrong with SVG Font that lacks <missing-glyph> element
: Text layout is wrong with SVG Font that lacks <missing-glyph> element
Product: WebKit
Classification: Unclassified
Component: SVG
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
Depends on:
  Show dependency treegraph
Reported: 2010-07-15 02:55 PDT by Hajime Morrita
Modified: 2010-07-15 05:54 PDT (History)
2 users (show)

See Also:

a reproduction. (1.00 KB, application/xhtml+xml)
2010-07-15 02:55 PDT, Hajime Morrita
no flags Details
patch v0 (29.09 KB, patch)
2010-07-15 03:44 PDT, Hajime Morrita
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2010-07-15 02:55:44 PDT
Created attachment 61629 [details]
a reproduction.

Text layout goes wrong when:

- There is a text styled with SVG Font
- The text has a character whose glyph is NOT contained in the SVG font.
- The SVG font does not have <missing-glypph>

This problem is originally reported http://code.google.com/p/chromium/issues/detail?id=48949 but not chromium specific.
Comment 1 Hajime Morrita 2010-07-15 03:44:43 PDT
Created attachment 61633 [details]
patch v0
Comment 2 Nikolas Zimmermann 2010-07-15 04:22:14 PDT
Comment on attachment 61633 [details]
patch v0

Great patch! Please fix typo before landing.

 +          sub-run, and a fallback to system font triggers such a comutation.
Typo: computation.
Comment 3 Hajime Morrita 2010-07-15 05:00:52 PDT
Thank you for the lightning review!
I'll land this after fix the typo.
Comment 4 Hajime Morrita 2010-07-15 05:54:58 PDT
Committed r63422: <http://trac.webkit.org/changeset/63422>