Bug 42352 - Text layout is wrong with SVG Font that lacks <missing-glyph> element
: Text layout is wrong with SVG Font that lacks <missing-glyph> element
Status: RESOLVED FIXED
: WebKit
SVG
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-07-15 02:55 PST by
Modified: 2010-07-15 05:54 PST (History)


Attachments
a reproduction. (1.00 KB, application/xhtml+xml)
2010-07-15 02:55 PST, Hajime Morrita
no flags Details
patch v0 (29.09 KB, patch)
2010-07-15 03:44 PST, Hajime Morrita
zimmermann: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-07-15 02:55:44 PST
Created an attachment (id=61629) [details]
a reproduction.

Text layout goes wrong when:

- There is a text styled with SVG Font
- The text has a character whose glyph is NOT contained in the SVG font.
- The SVG font does not have <missing-glypph>

This problem is originally reported http://code.google.com/p/chromium/issues/detail?id=48949 but not chromium specific.
------- Comment #1 From 2010-07-15 03:44:43 PST -------
Created an attachment (id=61633) [details]
patch v0
------- Comment #2 From 2010-07-15 04:22:14 PST -------
(From update of attachment 61633 [details])
Great patch! Please fix typo before landing.

WebCore/ChangeLog:7
 +          sub-run, and a fallback to system font triggers such a comutation.
Typo: computation.
------- Comment #3 From 2010-07-15 05:00:52 PST -------
Thank you for the lightning review!
I'll land this after fix the typo.
------- Comment #4 From 2010-07-15 05:54:58 PST -------
Committed r63422: <http://trac.webkit.org/changeset/63422>