Bug 42338 - Avoid creating huge compositing layers for elements that project outside the viewport
Summary: Avoid creating huge compositing layers for elements that project outside the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-07-14 22:51 PDT by Simon Fraser (smfr)
Modified: 2010-07-15 13:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (35.45 KB, patch)
2010-07-14 23:01 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (49.85 KB, patch)
2010-07-15 12:27 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-07-14 22:51:02 PDT
When a page has an abs. pos. div at -1000px, -1000px, or uses text-indent: -9999px, then we should avoid making huge, tiled compositing layers to try to encompass these elements.

More practically, this means constraining compositing layer size to the size of the enclosing document, or the enclosing overflow div.
Comment 1 Simon Fraser (smfr) 2010-07-14 22:51:31 PDT
<rdar://problem/8187624>
Comment 2 Simon Fraser (smfr) 2010-07-14 23:01:07 PDT
Created attachment 61609 [details]
Patch
Comment 3 Simon Fraser (smfr) 2010-07-14 23:02:22 PDT
Comment on attachment 61609 [details]
Patch

Not yet ready for review. enclosingOverflowScrollAncestor() should look for any overflow/clipping, not just those that result in scrolling.
Comment 4 Simon Fraser (smfr) 2010-07-14 23:04:05 PDT
Comment on attachment 61609 [details]
Patch

s/convertContainerToLocalQuadI/convertContainerToLocalQuad
Comment 5 Simon Fraser (smfr) 2010-07-15 12:27:46 PDT
Created attachment 61701 [details]
Patch
Comment 6 Simon Fraser (smfr) 2010-07-15 13:09:58 PDT
http://trac.webkit.org/changeset/63452
Comment 7 WebKit Review Bot 2010-07-15 13:43:26 PDT
http://trac.webkit.org/changeset/63452 might have broken SnowLeopard Intel Release (Tests)