Bug 42310 - Make sure that mixed interpreter/jit builds don't try to use the jit if the allocator fails
Summary: Make sure that mixed interpreter/jit builds don't try to use the jit if the a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-14 19:08 PDT by Oliver Hunt
Modified: 2010-07-14 21:30 PDT (History)
1 user (show)

See Also:


Attachments
Patch (25.76 KB, patch)
2010-07-14 19:14 PDT, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-07-14 19:08:07 PDT
Make sure that mixed interpreter/jit builds don't try to use the jit if the allocator fails
Comment 1 Oliver Hunt 2010-07-14 19:14:43 PDT
Created attachment 61596 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-14 19:20:38 PDT
Attachment 61596 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:453:  lock_holder is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:461:  lock_holder is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:470:  lock_holder is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2010-07-14 21:30:29 PDT
Committed r63404: <http://trac.webkit.org/changeset/63404>