Bug 42303 - Backfill DNS and connect times rather than exposing hard zeros
Summary: Backfill DNS and connect times rather than exposing hard zeros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 30685
  Show dependency tree / graph
 
Reported: 2010-07-14 16:46 PDT by Tony Gentilcore
Modified: 2010-07-15 08:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.45 KB, patch)
2010-07-14 17:04 PDT, Tony Gentilcore 		fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-07-14 16:46:11 PDT 
Backfill DNS and connect times rather than exposing hard zeros
Comment 1 Tony Gentilcore 2010-07-14 17:04:21 PDT 
Created attachment 61583 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2010-07-14 23:50:34 PDT 
Comment on attachment 61583 [details]
Patch

WebCore/page/Timing.cpp:58
 +  static unsigned long long toIntegerMilliseconds(double milliseconds)
nit: move to the top of the file so that the Timing methods are not interrupted
by a non-Timing method.  it isn't a real readability issue now, but once you
add an interrupt like this, someone will add more, and pretty soon you'll get
half of your class implemented in one section of the file and the other half
in another :(


R=me
Comment 3 Tony Gentilcore 2010-07-15 08:13:36 PDT 
(In reply to comment #2)
> (From update of attachment 61583 [details])
> WebCore/page/Timing.cpp:58
>  +  static unsigned long long toIntegerMilliseconds(double milliseconds)
> nit: move to the top of the file so that the Timing methods are not interrupted
> by a non-Timing method.  it isn't a real readability issue now, but once you
> add an interrupt like this, someone will add more, and pretty soon you'll get
> half of your class implemented in one section of the file and the other half
> in another :(
> 

Make sense. Done.

> 
> R=me
Comment 4 Tony Gentilcore 2010-07-15 08:16:13 PDT 
Committed r63426: <http://trac.webkit.org/changeset/63426>