Bug 42301 - [Chromium] Use the unique ID instead of the profile label to identify the accepted AutoFill suggestion.
Summary: [Chromium] Use the unique ID instead of the profile label to identify the acc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-14 16:05 PDT by James Hawkins
Modified: 2010-07-14 18:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.27 KB, patch)
2010-07-14 16:06 PDT, James Hawkins 		fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Hawkins 2010-07-14 16:05:32 PDT 
[Chromium] Use the unique ID instead of the profile label to identify the accepted AutoFill suggestion.
Comment 1 James Hawkins 2010-07-14 16:06:53 PDT 
Created attachment 61579 [details]
Patch
Comment 2 David Holloway 2010-07-14 16:31:39 PDT 
LGTM.
Comment 3 Darin Fisher (:fishd, Google) 2010-07-14 16:55:37 PDT 
Comment on attachment 61579 [details]
Patch

WebKit/chromium/public/WebView.h:258
 +      // Notifies the WebView that AutoFill suggestions are available for a node.
it might be nice to explain what the uniqueIDs parameter is
all about.  it isn't very obvious from reading the signature
of the method.

R=me
Comment 4 James Hawkins 2010-07-14 17:20:08 PDT 
Committed r63379: <http://trac.webkit.org/changeset/63379>
Comment 5 James Robinson 2010-07-14 18:00:07 PDT 
This doesn't compile in debug. WebViewImpl.cpp:1740