Bug 42296 - Add NetscapePluginStream class
Summary: Add NetscapePluginStream class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-14 15:33 PDT by Anders Carlsson
Modified: 2010-07-14 15:53 PDT (History)
0 users

See Also:

Attachments
Patch (9.93 KB, patch)
2010-07-14 15:34 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-14 15:33:40 PDT 
Add NetscapePluginStream class
Comment 1 Anders Carlsson 2010-07-14 15:34:34 PDT 
Created attachment 61575 [details]
Patch
Comment 2 Darin Adler 2010-07-14 15:36:02 PDT 
Comment on attachment 61575 [details]
Patch

> +NetscapePluginStream::NetscapePluginStream(NetscapePlugin* plugin, uint64_t streamID, bool sendNotification, void* notificationData)

bool is no fun

> +    NetscapePluginStream(NetscapePlugin* plugin, uint64_t streamID, bool sendNotification, void* notificationData);

No need for the argument name "plugin".

> +    RefPtr<NetscapePlugin> m_plugin;

If this class holds a ref to the plugin then the argument should be PassRefPtr<NetscapePlugin>, not NetscapePlugin*.
Comment 3 Anders Carlsson 2010-07-14 15:53:46 PDT 
Committed r63364: <http://trac.webkit.org/changeset/63364>