Bug 42290 – html5lib/runner.html fails after http://trac.webkit.org/changeset/63338/

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

html5lib/runner.html fails after http://trac.webkit.org/changeset/63338/

[Ojan Vafai]

Created attachment 61569 [details]
Patch

[Adam Barth]

Comment on attachment 61569 [details]
Patch

Sigh.

Why are these different????

+        * platform/chromium-mac/html5lib/runner-expected.txt:
+        * platform/chromium-win/html5lib/runner-expected.txt:

[Eric Seidel (no email)]

Comment on attachment 61569 [details]
Patch

You don't need a review on this.  Silly v8.

[Ojan Vafai]

(In reply to comment #2)
> (From update of attachment 61569 [details])
> Sigh.
> 
> Why are these different????
> 
> +        * platform/chromium-mac/html5lib/runner-expected.txt:
> +        * platform/chromium-win/html5lib/runner-expected.txt:

I wondered the same thing. I'm not sure. I think it might be that someone didn't set the right EOL style on the windows one, so it's all CRLFed. But, I'm just trying to green the tree for now. If I find time, I'll try and resolve the difference later.

[Peter Kasting]

(In reply to comment #3)
> (From update of attachment 61569 [details])
> You don't need a review on this.  Silly v8.

Right, this can (and should) just go in without review (or even a bug) as "Update Chromium test expectations".  Sadly, until we get V8/JSC to agree on their errors, we have to do this every time there's an html5 parser change :(.  That issue is making slow progress elsewhere.

(In reply to comment #2)
> Why are these different????
> 
> +        * platform/chromium-mac/html5lib/runner-expected.txt:
> +        * platform/chromium-win/html5lib/runner-expected.txt:

They only differ in line endings.  I'm 99.999% sure the chromium-mac expectation can be removed if the chromium-win one is converted to LF line endings (stamp it with an svn:eol-style to make sure it stays that way).

[Adam Barth]

This patch was either landed or is infinitely out of date by now.