Bug 42290 - html5lib/runner.html fails after http://trac.webkit.org/changeset/63338/
Summary: html5lib/runner.html fails after http://trac.webkit.org/changeset/63338/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-14 14:30 PDT by Ojan Vafai
Modified: 2010-08-10 22:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.84 KB, patch)
2010-07-14 14:42 PDT, Ojan Vafai 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-07-14 14:30:11 PDT 
html5lib/runner.html fails after http://trac.webkit.org/changeset/63338/
Comment 1 Ojan Vafai 2010-07-14 14:42:17 PDT 
Created attachment 61569 [details]
Patch
Comment 2 Adam Barth 2010-07-14 14:56:48 PDT 
Comment on attachment 61569 [details]
Patch

Sigh.

Why are these different????

+        * platform/chromium-mac/html5lib/runner-expected.txt:
+        * platform/chromium-win/html5lib/runner-expected.txt:
Comment 3 Eric Seidel (no email) 2010-07-14 14:57:09 PDT 
Comment on attachment 61569 [details]
Patch

You don't need a review on this.  Silly v8.
Comment 4 Ojan Vafai 2010-07-14 15:02:04 PDT 
(In reply to comment #2)
> (From update of attachment 61569 [details])
> Sigh.
> 
> Why are these different????
> 
> +        * platform/chromium-mac/html5lib/runner-expected.txt:
> +        * platform/chromium-win/html5lib/runner-expected.txt:

I wondered the same thing. I'm not sure. I think it might be that someone didn't set the right EOL style on the windows one, so it's all CRLFed. But, I'm just trying to green the tree for now. If I find time, I'll try and resolve the difference later.
Comment 5 Peter Kasting 2010-07-14 15:03:56 PDT 
(In reply to comment #3)
> (From update of attachment 61569 [details])
> You don't need a review on this.  Silly v8.

Right, this can (and should) just go in without review (or even a bug) as "Update Chromium test expectations".  Sadly, until we get V8/JSC to agree on their errors, we have to do this every time there's an html5 parser change :(.  That issue is making slow progress elsewhere.

(In reply to comment #2)
> Why are these different????
> 
> +        * platform/chromium-mac/html5lib/runner-expected.txt:
> +        * platform/chromium-win/html5lib/runner-expected.txt:

They only differ in line endings.  I'm 99.999% sure the chromium-mac expectation can be removed if the chromium-win one is converted to LF line endings (stamp it with an svn:eol-style to make sure it stays that way).
Comment 6 Adam Barth 2010-08-10 22:28:09 PDT 
This patch was either landed or is infinitely out of date by now.