Bug 42283 - Define setPrivateBrowsingEnabled()
Summary: Define setPrivateBrowsingEnabled()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 41801
  Show dependency treegraph
Reported: 2010-07-14 13:21 PDT by Robert Hogan
Modified: 2010-08-06 20:37 PDT (History)
2 users (show)

See Also:

Patch (1.63 KB, patch)
2010-07-16 03:06 PDT, Robert Hogan
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-07-14 13:21:26 PDT
'Private Browsing' actually doesn't have a formal definition in WebCore - at least not in the code.

WebKit on the other hand is not short of possible definitions:

    \value PrivateBrowsingEnabled Private browsing prevents WebKit from
        recording visited pages in the history and storing web page icons. This is disabled by default.

    @abstract If private browsing is enabled, WebKit will not store information
    about sites the user visits.

    * Whether to enable private browsing mode. Private browsing mode prevents
    * WebKit from updating the global history and storing any session
    * information e.g., on-disk cache, as well as suppressing any messages
    * from being printed into the (javascript) console.

Ports are at liberty to implement their own additional behaviour to private browsing, and clients even more.

Define 'private browsing' in WebCore so that it is not subject to feature creep (such as protecting against remote tracking) and potential confusion (what clients brand 'private browsing' may not be within the scope of WebCore's definition of private browsing).
Comment 1 Robert Hogan 2010-07-16 03:06:18 PDT
Created attachment 61789 [details]
Comment 2 Antonio Gomes 2010-07-16 06:35:10 PDT
good stuff!
Comment 3 Adam Barth 2010-07-27 07:15:55 PDT
Comment on attachment 61789 [details]

Please remove these extra spaces before landing.
Comment 4 Adam Barth 2010-08-06 20:37:53 PDT
Committed r64893: <http://trac.webkit.org/changeset/64893>