Bug 42282 - Fix enum value names for Navigation.{idl|h}
Summary: Fix enum value names for Navigation.{idl|h}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 30685
  Show dependency tree / graph
 
Reported: 2010-07-14 13:17 PDT by Tony Gentilcore
Modified: 2010-07-14 14:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.37 KB, patch)
2010-07-14 13:20 PDT, Tony Gentilcore 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-07-14 13:17:29 PDT 
Fix enum value names for Navigation.{idl|h}
Comment 1 Tony Gentilcore 2010-07-14 13:20:45 PDT 
Created attachment 61555 [details]
Patch
Comment 2 Darin Adler 2010-07-14 13:42:28 PDT 
Comment on attachment 61555 [details]
Patch

> +    enum NavigationType {
> +        NAVIGATE = 0,
> +        RELOAD = 1,
> +        BACK_FORWARD = 2,
> +    };

I don’t think it’s important to have those "= 0", "= 1", "= 2" there.

I’m surprised this patch doesn’t remove DontCheckEnum from the IDL file.
Comment 3 Tony Gentilcore 2010-07-14 13:50:09 PDT 
(In reply to comment #2)
> (From update of attachment 61555 [details])
> > +    enum NavigationType {
> > +        NAVIGATE = 0,
> > +        RELOAD = 1,
> > +        BACK_FORWARD = 2,
> > +    };
> 
> I don’t think it’s important to have those "= 0", "= 1", "= 2" there.

Okay, I'll pull them.

> 
> I’m surprised this patch doesn’t remove DontCheckEnum from the IDL file.

DontCheckEnum was not added to this IDL file because it is guarded by ENABLE(WEB_TIMING), which is currently off by default. I got the compile error as soon as I enabled it locally.
Comment 4 Tony Gentilcore 2010-07-14 14:40:30 PDT 
Committed r63356: <http://trac.webkit.org/changeset/63356>