Bug 42281 – -webkit-transition Fails on Multiple text-shadow Shadows

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[DeathByNukes]

Created attachment 61554 [details]
Demonstration

When using -webkit-transition on a text-shadow containing 3 or more shadows, only the first and last shadows will be visible during the transition; all other shadows disappear until it is over.
If I interrupt and resume the transition, the first shadow will jump to the destination's color and reset to position 0,0 with 0 blur then transition from there to the destination.

I have tested this in "AppleWebKit/533.9 Chrome/6.0.401.1" and "AppleWebKit/533.16 Version/5.0 Safari/533.16" in Windows 7 x64.

[Simon Fraser (smfr)]

Confirming.

[Simon Fraser (smfr)]

Created attachment 75736 [details]
Patch

Comment on attachment 75736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75736&action=review

> WebCore/page/animation/AnimationBase.cpp:372
> +                newShadowData = lastShadow = blendedShadow;
> +            else {
> +                lastShadow->setNext(blendedShadow);
> +                lastShadow = blendedShadow;
> +            }

I think a better way to write this, which also avoids the forbidden double assignment, would be:
if (!newShadowData)
    newShadowData = blendedShadow;
else
    lastShadow->setNext(blendedShadow);
lastShadow = blendedShadow;

[Simon Fraser (smfr)]

Created attachment 75755 [details]
Patch

[WebKit Review Bot]

Attachment 75755 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'HEAD'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/73462

[Simon Fraser (smfr)]

*** Bug 39703 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

*** Bug 29602 has been marked as a duplicate of this bug. ***