WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
42266
[GTK] autogen.sh not executed if build-webkit options change
https://bugs.webkit.org/show_bug.cgi?id=42266
Summary
[GTK] autogen.sh not executed if build-webkit options change
Philippe Normand
Reported
2010-07-14 09:00:26 PDT
If I build-webkit with --disable-video and later on if I want to rebuild with video support then build-webkit --enable-video should re-execute autogen.sh or configure. It's not the case currently I believe. One solution could be to make build-webkit save the options somewhere and for the GTK port when the options change compared to last build, re-run autogen.sh or configure.
Attachments
Patch for this issue
(2.47 KB, patch)
2010-08-11 09:42 PDT
,
Martin Robinson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Robinson
Comment 1
2010-08-11 09:42:44 PDT
Created
attachment 64129
[details]
Patch for this issue
Alejandro G. Castro
Comment 2
2010-08-11 12:27:23 PDT
Tested the patch disabling and enabling a feature in the file and it works for me. I found an issue doing it not related with the patch (
bug 43866
) that could cause problems doing this kind of changes.
Kenneth Rohde Christiansen
Comment 3
2010-08-14 07:54:40 PDT
Comment on
attachment 64129
[details]
Patch for this issue You probably want to skip the previous-autogen-arguments.txt in .gitignore
Martin Robinson
Comment 4
2010-08-14 17:52:38 PDT
Comment on
attachment 64129
[details]
Patch for this issue Clearing flags on attachment: 64129 Committed
r65377
: <
http://trac.webkit.org/changeset/65377
>
Martin Robinson
Comment 5
2010-08-14 17:52:44 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6
2010-08-14 18:23:35 PDT
http://trac.webkit.org/changeset/65377
might have broken GTK Linux 32-bit Release
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug