Bug 42266 - [GTK] autogen.sh not executed if build-webkit options change
Summary: [GTK] autogen.sh not executed if build-webkit options change
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on: 43866
  Show dependency treegraph
Reported: 2010-07-14 09:00 PDT by Philippe Normand
Modified: 2010-08-14 18:23 PDT (History)
5 users (show)

See Also:

Patch for this issue (2.47 KB, patch)
2010-08-11 09:42 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-07-14 09:00:26 PDT
If I build-webkit with --disable-video and later on if I want to rebuild with video support then build-webkit --enable-video should re-execute autogen.sh or configure. It's not the case currently I believe.

One solution could be to make build-webkit save the options somewhere and for the GTK port when the options change compared to last build, re-run autogen.sh or configure.
Comment 1 Martin Robinson 2010-08-11 09:42:44 PDT
Created attachment 64129 [details]
Patch for this issue
Comment 2 Alejandro G. Castro 2010-08-11 12:27:23 PDT
Tested the patch disabling and enabling a feature in the file and it works for me. I found an issue doing it not related with the patch (bug 43866) that could cause problems doing this kind of changes.
Comment 3 Kenneth Rohde Christiansen 2010-08-14 07:54:40 PDT
Comment on attachment 64129 [details]
Patch for this issue

You probably want to skip the previous-autogen-arguments.txt in .gitignore
Comment 4 Martin Robinson 2010-08-14 17:52:38 PDT
Comment on attachment 64129 [details]
Patch for this issue

Clearing flags on attachment: 64129

Committed r65377: <http://trac.webkit.org/changeset/65377>
Comment 5 Martin Robinson 2010-08-14 17:52:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-08-14 18:23:35 PDT
http://trac.webkit.org/changeset/65377 might have broken GTK Linux 32-bit Release